Improve bash scripts

lint_string.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
-grep -rE --include="*.rs" "$1" .
-if [ $? -eq 0 ]; then
+
+if grep -rE --include="*.rs" "$1" .; then
     echo "'$1's found."
     exit 1
 else

manual_test.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 # Does not cover the complete function
 # Run it manually to ensure that we didn't break clap
 
@@ -33,8 +33,8 @@ commands=(
 for cmd in "${commands[@]}"
 do
   echo "Executing command: $cmd"
-  eval "$cmd"
-  if [ $? -ne 0 ]; then
+
+  if ! eval "$cmd"; then
     echo "Command failed: $cmd"
     exit 1
   fi

push_aur.sh

@@ -1,12 +1,13 @@
-#!/bin/sh
-cd ../tod-bin/
+#!/bin/bash
+
+cd ../tod-bin/ || exit
 git pull
-cd ../tod/
+cd ../tod/ || exit
 makepkg --printsrcinfo > ../tod-bin/.SRCINFO
 mv PKGBUILD ../tod-bin/
-rm *.tar.gz
-cd ../tod-bin/
+rm ./*.tar.gz
+cd ../tod-bin/ || exit
 git add .
 git commit -m "new version"
 git push aur
-cd ../tod
+cd ../tod || exit

setup_aur.sh

@@ -1,5 +1,7 @@
-cd ~/dev
+#!/bin/bash
+
+cd ~/dev || exit
 git clone ssh://[email protected]/tod-bin.git
-cd tod-bin
+cd tod-bin || exit
 git remote add aur ssh://[email protected]/tod-bin.git
-cd ../tod
+cd ../tod || exit

src/request.rs

@@ -126,6 +126,7 @@ pub fn complete_item(config: &Config) -> Result<String, String> {
 }
 
 /// Post to Todoist via sync API
+/// We use sync when we want natural languague processing.
 fn post_todoist_sync(
     config: &Config,
     url: String,
@@ -161,6 +162,7 @@ fn post_todoist_sync(
 }
 
 /// Post to Todoist via REST api
+/// We use this when we want more options and don't need natural language processing
 fn post_todoist_rest(
     config: &Config,
     url: String,

test.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 cargo fmt &&
 cargo clippy -- -D warnings &&
 cargo tarpaulin -o lcov &&

update_test.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 cargo update && \
 ./test.sh && \
 ./manual_test.sh && \