Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import from dist in example archi #45

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: import from dist in example archi #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4d710
fix: import from dist in example archi
SolP-Aleios Oct 20, 2023
36cab2d
ci: add build in pr ci
SolP-Aleios Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ defaults:

jobs:
run-tests:
name: Deploy and Run Tests
name: Deploy and Run Tests
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
Expand All @@ -39,6 +39,8 @@ jobs:
cache: "pnpm"
- name: Install Top Level Dependencies
run: pnpm install --frozen-lockfile
- name: Build
run: pnpm build
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v1
with:
Expand All @@ -61,5 +63,5 @@ jobs:
pnpm deploy-dev
- name: "🧪 Test unit and integration"
run: pnpm test --verbose
- name: '🧪 Test linter'
- name: "🧪 Test linter"
run: pnpm lint-test
4 changes: 2 additions & 2 deletions example-architecture/consumer/functions/consumer/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { DynamoDBClient } from "@aws-sdk/client-dynamodb";
import { DynamoDBDocumentClient, PutCommand } from "@aws-sdk/lib-dynamodb";
import { Contract } from "dist/types/Contract";
import { getEnvVariable } from "example-architecture/helpers/getEnvVariable";
import { Contract } from "src/types/Contract";

type EventBridgeConsumerEvent = {
id: string;
Expand All @@ -14,7 +14,7 @@
} & Contract;

export const handler = async (
event: EventBridgeConsumerEvent,
event: EventBridgeConsumerEvent

Check failure on line 17 in example-architecture/consumer/functions/consumer/handler.ts

View workflow job for this annotation

GitHub Actions / Deploy and Run Tests 

Insert `,`
): Promise<void> => {
const dynamoDB = DynamoDBDocumentClient.from(new DynamoDBClient());

Expand Down
1 change: 1 addition & 0 deletions example-architecture/consumer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"typescript": "~5.1.6"
},
"dependencies": {
"@aleios-cloud/eventbridge-toolbox": "latest",
"@aws-cdk/aws-events-targets": "^1.204.0",
"@aws-cdk/aws-iam": "^1.204.0",
"@aws-sdk/client-dynamodb": "^3.391.0",
Expand Down
928 changes: 531 additions & 397 deletions example-architecture/consumer/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion example-architecture/events/contracts/personRegisteredContractV1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Contract } from "src/types";
import { Contract } from "dist/types";
export interface PersonRegisteredContract extends Contract {
"detail-type": "PersonRegisteredContract";
detail: {
Expand Down
2 changes: 1 addition & 1 deletion example-architecture/events/contracts/personRegisteredContractV2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Contract } from "src/types";
import { Contract } from "dist/types";
export interface PersonRegisteredContract extends Contract {
"detail-type": "PersonRegisteredContract";
detail: {
Expand Down
1 change: 1 addition & 0 deletions example-architecture/events/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"typescript": "~5.1.6"
},
"dependencies": {
"@aleios-cloud/eventbridge-toolbox": "latest",
"@aws-sdk/client-eventbridge": "^3.387.0",
"aws-sdk": "^2.1431.0"
}
Expand Down
Loading
Loading