-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predictable property order for both grid & form #130
base: master
Are you sure you want to change the base?
Conversation
setColumns & setVisibleProperties calls now become more like optional configuration than must have. Removes a ton of nasty looking non-type configuration code. BTW. Now that property order is "correct", in many cases an inverted approach for visible column/property configuration would be often better, something like setHiddenColumns/Properties 🤔 And yeah, next step would be to replace Binder with FormBinder from Viritin to make crossfield validation work properly 🤓
Added property hiding, partly to VGrid, so no release for transitive dependency yet. Will cut a version still soon... |
Dependency now syncing to Maven Central |
@mstahv - Thanks for the contribution. Is there any way to implement this so that no additional dependencies are added? |
Sure, just copy all the code from dependencies 🤪 Jackson (that is mostly used here) is a dependency coming in via Vaadin, that isn't going anywhere. VGrid from Viritin is essentially the Vaadin Grid, but with proper property handling (and some other very handy features). Hiding its more specific type (at least by default), would be nice, but then the column hiding would need to be moved to the top level. On my list would be to add buillt in support for enums, lists/sets of basic data types & simple objects, Java recorods and doing some UX improvements. For those Viritin would need to be cloned in completely 🤷♂️ BTW. Some obsolete code was left in the example. Removed. |
Added some additional cleanup (thanks to Vaadin improvements) and removed H2 config so that the demo app starts without additional tricks. As a DB fellow you ought to update that to use TestContainers & MariaDB 🤓 |
Yeah, I wasn't clear or precise. I was referring to the dependency added to the Thanks a lot for the additional cleanup. |
setColumns & setVisibleProperties calls now become more like optional configuration than must have. Removes a ton of nasty looking non-type configuration code.
BTW. Now that property order is "correct", in many cases an inverted approach for visible column/property configuration would be often better, something like setHiddenColumns/Properties 🤔
And yeah, next step would be to replace Binder with FormBinder from Viritin to make crossfield validation work properly 🤓