Fixing default ngrok.yml config path.

alexdlaird · Aug 26, 2021 · 9d3a9f6 · 9d3a9f6
1 parent 521d67e
commit 9d3a9f6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,10 +3,13 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [1.4.2](https://github.com/alexdlaird/java-ngrok/compare/1.4.0...1.4.2) - 2021-08-26
+## [1.4.3](https://github.com/alexdlaird/java-ngrok/compare/1.4.0...1.4.3) - 2021-08-26
 ### Added
 - Build improvements.
 - Documentation improvements.
 
+### Fixed
+- If no `configPath` is set in `JavaNgrokConfig`, now properly defaults to `~/.ngrok2/ngrok.yml`.
+
 ## [1.4.0](https://github.com/alexdlaird/java-ngrok/releases/tag/1.4.0) - 2021-08-25
 - Java 8 support, which will not be actively maintained, is available through the `java8-ngrok` artifact on [Maven Central](https://maven-badges.herokuapp.com/maven-central/com.github.alexdlaird/java8-ngrok/).
diff --git a/src/main/java/com/github/alexdlaird/ngrok/conf/JavaNgrokConfig.java b/src/main/java/com/github/alexdlaird/ngrok/conf/JavaNgrokConfig.java
@@ -172,7 +172,7 @@ public Builder withNgrokPath(final Path ngrokPath) {
         }
 
         /**
-         * The path to the <code>ngrok</code> config file, defaults to <code>~/.ngrok2/config.yml</code>.
+         * The path to the <code>ngrok</code> config file, defaults to <code>~/.ngrok2/ngrok.yml</code>.
          */
         public Builder withConfigPath(final Path configPath) {
             this.configPath = configPath;

diff --git a/src/main/java/com/github/alexdlaird/ngrok/installer/NgrokInstaller.java b/src/main/java/com/github/alexdlaird/ngrok/installer/NgrokInstaller.java
@@ -78,7 +78,7 @@ public class NgrokInstaller {
     public static final String FREEBSD = "FREEBSD";
     public static final List<String> UNIX_BINARIES = Stream.of(MAC, LINUX, FREEBSD).collect(Collectors.toList());
     public static final Path DEFAULT_NGROK_PATH = Paths.get(System.getProperty("user.home"), ".ngrok2", NgrokInstaller.getNgrokBin());
-    public static final Path DEFAULT_CONFIG_PATH = Paths.get(System.getProperty("user.home"), ".ngrok2", "config.yml");
+    public static final Path DEFAULT_CONFIG_PATH = Paths.get(System.getProperty("user.home"), ".ngrok2", "ngrok.yml");
 
     private static final List<String> VALID_LOG_LEVELS = Stream.of("info", "debug").collect(Collectors.toList());