This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Add a jaas_ prefix to the service name #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will generate the service name on the client and prefix it with jaas_. If by chance this name already exists we will exit and print the informing error. We might introduce a retry logic in the future. Signed-off-by: Dominik Dingel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will generate the service name on the client and prefix it with
jaas_. If by chance this name already exists we will exit and print the
informing error. We might introduce a retry logic in the future.
Signed-off-by: Dominik Dingel [email protected]
Description
We generate the name and prefix it with jaas
Motivation and Context
#22
How Has This Been Tested?
Manual created a service and let jaas create an additional service with a given name (changed in code).
Types of changes
Checklist: