Don't leak the local time and default services in the handshake #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use "/pynode:0.0.1/" for a user-agent, same as https://github.com/laanwj/bitcoin-submittx https://github.com/laanwj/bitcoin-submittx/blob/302d2d79d4060d549d5b0cea0bf70fedc8049bde/bitcoin-submittx#L28 This is what a proposed feature in Bitcoin Core does: bitcoin/bitcoin#29415 https://github.com/bitcoin/bitcoin/blob/057c79365c35ad802584379ebedb8b6542216214/src/net_processing.cpp#L1641-L1648
vasild
commented
May 23, 2024
| receiver: bitcoin::p2p::Address { | ||
| services: bitcoin::p2p::ServiceFlags::default(), | ||
| services: bitcoin::p2p::ServiceFlags::NONE, | ||
| address: [0; 8], |
There was a problem hiding this comment.
What is this [0; 8]? Does it create 8 zero bytes? If yes, then that should be 16 instead of 8 bytes.
https://developer.bitcoin.org/reference/p2p_networking.html#version
There was a problem hiding this comment.
The address struct looks like this:
/// A message which can be sent on the Bitcoin network
#[derive(Clone, PartialEq, Eq, Hash)]
pub struct Address {
/// Services provided by the peer whose address this is
pub services: ServiceFlags,
/// Network byte-order ipv6 address, or ipv4-mapped ipv6 address
pub address: [u16; 8],
/// Network port
pub port: u16,
}It is indeed 16 bytes, but for some reason rust-bitcoin defines that as 8 shorts. So the end result is the same.
|
Useful additions, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use "/pynode:0.0.1/" for a user-agent, same as https://github.com/laanwj/bitcoin-submittx
https://github.com/laanwj/bitcoin-submittx/blob/302d2d79d4060d549d5b0cea0bf70fedc8049bde/bitcoin-submittx#L28
This is what a proposed feature in Bitcoin Core does: bitcoin/bitcoin#29415
https://github.com/bitcoin/bitcoin/blob/057c79365c35ad802584379ebedb8b6542216214/src/net_processing.cpp#L1641-L1648