Fix missing add_trust_anchors method due to lax rustls versioning #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2023
Upon upgrading to 2.8.0, I got the following compile error from inside `ureq`:
error[E0599]: no method named `add_trust_anchors` found for struct `RootCertStore` in the current scope
--> /home/cdown/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ureq-2.8.0/src/rtls.rs:102:16
|
102 | root_store.add_trust_anchors(webpki_roots::TLS_SERVER_ROOTS.iter().map(|ta| {
| -----------^^^^^^^^^^^^^^^^^ help: there is a method with a similar name: `add_server_trust_anchors`
The reason is because `add_trust_anchors` was only added in rustls
0.21.6, but ureq only specifies that any 0.21 is required. As such, if
you are already using a compliant, earlier version, the method does not
exist and the compile fails.
Pin to >=0.21.6 to make sure this method exists.
Originally introduced in 50fd1fe ("Update deps").
cdown
force-pushed
the
cdown/2023-11-02/fix_rustls_version
branch
from
372a9e7 to
2e2c1fc
Compare
|
Hi there, let me know if you see any changes needed :-) Just to show this is a general problem and not just with my repositories, some other PRs failing with this issue I see from a cursory look: |
|
Sorry! It fell off my radar. Thanks for reminding me. |
|
Thanks for looking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon upgrading to 2.8.0, I got the following compile error from inside
ureq:The reason is because
add_trust_anchorswas only added in rustls 0.21.6, but ureq only specifies that any 0.21 is required. As such, if you are already using a compliant, earlier version, the method does not exist and the compile fails.Pin to >=0.21.6 to make sure this method exists.
Originally introduced in 50fd1fe ("Update deps").