forked from shadowproject/shadow
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable testing suite #43
Merged
HLXEasy
merged 23 commits into
aliascash:feature/reactivateUnittests
from
bitcoinx2:fix-unit-tests
Dec 4, 2021
Merged
Re-enable testing suite #43
HLXEasy
merged 23 commits into
aliascash:feature/reactivateUnittests
from
bitcoinx2:fix-unit-tests
Dec 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Official release build 4.3.0
Release build 4.3.1
Release build 4.4.0
Prevents interfering with testing which uses its own init and shutdown routines
Undo changes done in commit 579b231
Previously broken by commit 84c4eac (removed messaging capability)
Broken by commit c84f510
Previously broken by commit e6e0018 (changed base58Prefixes) The values used here are simply those expected by the test. Please review them for plausibility!
Previously broken by commit e6e0018 (changed base58Prefixes) The values used here are simply those expected by the test. Please review them for plausibility!
Previously broken by commit e6e0018 (removed checkpoints)
Previously broken by commit e6e0018 (changed base58Prefixes) The values used here are simply those expected by the test. Please review them for plausibility!
The values used here are simply those expected by the test. Please review them for plausibility!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reactivate the existing testing suite. Closes #4
These tests have apparently not used since the beginning of Spectrecoin. Most test vectors still refer to the base58 prefixes of ShadowCash (SDC) which is (presumably) the main reason why tests are failing.
Most notable changes:
For changing the test vectors I assume that the tests themselves are still correct, i.e. I simply inserted the values expected by the test. Admittedly this is a bad practice but serves as a starting point to see which test units are still compatible with our current code base in general. Future work should focus on reviewing the used test values and verifying their plausibility with regards to the desired behavior of the wallet.
As it stands now, the tests can still be used for regression testing, i.e. verifying that future code changes do not change the current behavior of the wallet (which might not necessarily be the desired behavior).
There are still some open issues which appear on my system (linux 64 bit):
According to my investigation so far,
extkey_tests/extkey_serialise
fails in case of de-serialization of an empty vector of<unsigned char>
. This might in fact be a bug in the code base, not in the test. I don't know what the desired serialization should look like.I didn't investigate the memory access violation yet.
The current changes have only been tested on Linux so the build will probably fail for other platforms.