no-unused-vars

.eslintrc

@@ -33,7 +33,6 @@
     "no-plusplus": ["off"],
     "no-unused-expressions": ["off"],
     "global-require": ["off"],
-    "no-unused-vars": ["off"],
     "no-path-concat": ["off"],
     "prefer-rest-params": ["off"]
   }

lib/csv/csv.js

@@ -159,7 +159,7 @@ CSV.prototype = {
     var streamOptions = {
       encoding: options.encoding || 'utf8'
     };
-    var stream = fs.createWriteStream(filename, options);
+    var stream = fs.createWriteStream(filename, streamOptions);
 
     return this.write(stream, options);
   }

lib/csv/line-buffer.js

@@ -27,7 +27,7 @@ utils.inherits(LineBuffer, events.EventEmitter, {
   //  line: here is a line
   //  done: all lines emitted
 
-  write: function(chunk, encoding, callback) {
+  write: function(chunk, encoding) {
     // find line or lines in chunk and emit them if not corked
     // or queue them if corked
     var data = this.buffer ? this.buffer + chunk : chunk;
@@ -56,10 +56,10 @@ utils.inherits(LineBuffer, events.EventEmitter, {
     // tell the source I'm ready again
     this.emit('drain');
   },
-  setDefaultEncoding: function(encoding) {
+  setDefaultEncoding: function() {
     // ?
   },
-  end: function(chunk, encoding, callback) {
+  end: function(chunk, encoding) {
     if (this.buffer) {
       this.emit('line', this.buffer);
       this.buffer = null;

lib/doc/cell.js

@@ -7,7 +7,6 @@
 'use strict';
 
 var colCache = require('../utils/col-cache');
-var utils = require('../utils/utils');
 var Enums = require('./enums');
 var { slideFormula } = require('../utils/shared-formula');
 

lib/doc/worksheet.js

@@ -8,7 +8,6 @@
 
 var _ = require('../utils/under-dash');
 
-var utils = require('./../utils/utils');
 var colCache = require('./../utils/col-cache');
 var Range = require('./range');
 var Row = require('./row');
@@ -423,7 +422,7 @@ Worksheet.prototype = {
   },
 
   get hasMerges() {
-    return _.some(this._merges, function(merge, address) {
+    return _.some(this._merges, function(merge) {
       // TODO: this doesn't look right
       return true;
     });

lib/stream/xlsx/workbook-writer.js

@@ -10,7 +10,6 @@ var fs = require('fs');
 var Archiver = require('archiver');
 var PromishLib = require('../../utils/promish');
 
-var utils = require('../../utils/utils');
 var StreamBuf = require('../../utils/stream-buf');
 
 var RelType = require('../../xlsx/rel-type');

lib/stream/xlsx/worksheet-reader.js

@@ -6,7 +6,6 @@
 
 'use strict';
 
-var fs = require('fs');
 var events = require('events');
 var Sax = require('sax');
 
@@ -81,19 +80,17 @@ utils.inherits(WorksheetReader, events.EventEmitter, {
     this.emit('row', row);
   },
 
-  read: function(entry, options, hyperlinkReader) {
+  read: function(entry, options) {
     var self = this;
 
     var emitSheet = false;
-    var prepSheet = false;
     var emitHyperlinks = false;
     var hyperlinks = null;
     switch (options.worksheets) {
       case 'emit':
         emitSheet = true;
         break;
       case 'prep':
-        prepSheet = true;
         break;
       default:
         break;

lib/stream/xlsx/worksheet-writer.js

@@ -6,9 +6,6 @@
 
 'use strict';
 
-var fs = require('fs');
-
-var utils = require('../../utils/utils');
 var RelType = require('../../xlsx/rel-type');
 
 var colCache = require('../../utils/col-cache');

lib/utils/cell-matrix.js

@@ -7,8 +7,6 @@
 'use strict';
 
 var _ = require('./under-dash');
-
-var utils = require('./utils');
 var colCache = require('./col-cache');
 
 var CellMatrix = function(template) {

lib/utils/flow-control.js

@@ -189,13 +189,12 @@ utils.inherits(FlowControl, events.EventEmitter, {
     return !stemFlow;
   },
 
-  end: function(chunk, encoding, callback) {
+  end: function(chunk, encoding) {
     // Signal from up-stream
-    var self = this;
     this.queue.push({
-      callback: function() {
-        self.queue = null;
-        self.emit('finish');
+      callback: () => {
+        this.queue = null;
+        this.emit('finish');
       }
     });
     this._flush();

lib/utils/shared-formula.js

@@ -8,7 +8,7 @@
 
 var colCache = require('./col-cache');
 
-var cellRefRegex = /(([a-z_\-0-9]*)!)?[$]?([a-z]+)[$]?([1-9][0-9]*)/i;
+// var cellRefRegex = /(([a-z_\-0-9]*)!)?[$]?([a-z]+)[$]?([1-9][0-9]*)/i;
 var replacementCandidateRx = /(([a-z_\-0-9]*)!)?([a-z0-9_$]{2,})([(])?/ig;
 var CRrx = /^([$])?([a-z]+)([$])?([1-9][0-9]*)$/i;
 

lib/utils/stream-base64.js

@@ -1,18 +1,12 @@
 'use strict';
 
 var Stream = require('stream');
-var PromishLib = require('./promish');
-
 var utils = require('./utils');
-var StringBuf = require('./string-buf');
-
 
 // =============================================================================
 // StreamBase64 - A utility to convert to/from base64 stream
 // Note: does not buffer data, must be piped
-var StreamBuf = module.exports = function(options) {
-  options = options || {};
-
+var StreamBuf = module.exports = function() {
   // consuming pipe streams go here
   this.pipes = [];
 };
@@ -25,20 +19,14 @@ utils.inherits(StreamBuf, Stream.Duplex, {
   // unpipe(src) - unpipe() has been called on readable
   // error - duh
 
-  write: function(data, encoding, callback) {
-    if (encoding instanceof Function) {
-      callback = encoding;
-      encoding = 'utf8';
-    }
-    callback = callback || utils.nop;
-
+  write: function(/* data, encoding */) {
     return true;
   },
   cork: function() {
   },
   uncork: function() {
   },
-  end: function(chunk, encoding, callback) {
+  end: function(/* chunk, encoding, callback */) {
   },
 
   // readable
@@ -47,7 +35,7 @@ utils.inherits(StreamBuf, Stream.Duplex, {
   // event end - no more data
   // event close - optional, indicates upstream close
   // event error - duh
-  read: function(size) {
+  read: function(/* size */) {
   },
   setEncoding: function(encoding) {
     // causes stream.read or stream.on('data) to return strings of encoding instead of Buffer objects
@@ -59,7 +47,7 @@ utils.inherits(StreamBuf, Stream.Duplex, {
   },
   isPaused: function() {
   },
-  pipe: function(destination, options) {
+  pipe: function(/* destination, options */) {
     // add destination to pipe list & write current buffer
     this.pipes.push(destination);
   },
@@ -69,12 +57,12 @@ utils.inherits(StreamBuf, Stream.Duplex, {
       return pipe !== destination;
     });
   },
-  unshift: function(chunk) {
+  unshift: function(/* chunk */) {
     // some numpty has read some data that's not for them and they want to put it back!
     // Might implement this some day
     throw new Error('Not Implemented');
   },
-  wrap: function(stream) {
+  wrap: function(/* stream */) {
     // not implemented
     throw new Error('Not Implemented');
   }

lib/utils/stream-buf.js

@@ -331,7 +331,7 @@ utils.inherits(StreamBuf, Stream.Duplex, {
   isPaused: function() {
     return !!this.paused;
   },
-  pipe: function(destination, options) {
+  pipe: function(destination) {
     // add destination to pipe list & write current buffer
     this.pipes.push(destination);
     if (!this.paused && this.buffers.length) {
@@ -344,12 +344,12 @@ utils.inherits(StreamBuf, Stream.Duplex, {
       return pipe !== destination;
     });
   },
-  unshift: function(chunk) {
+  unshift: function(/* chunk */) {
     // some numpty has read some data that's not for them and they want to put it back!
     // Might implement this some day
     throw new Error('Not Implemented');
   },
-  wrap: function(stream) {
+  wrap: function(/* stream */) {
     // not implemented
     throw new Error('Not Implemented');
   }

lib/utils/string-buf.js

@@ -6,8 +6,6 @@
 
 'use strict';
 
-var utils = require('./utils');
-
 // StringBuf - a way to keep string memory operations to a minimum
 // while building the strings for the xml files
 var StringBuf = module.exports = function(options) {

lib/utils/string-builder.js

@@ -6,14 +6,9 @@
 
 'use strict';
 
-
-var utils = require('./utils');
-
-var nop = function() {};
-
 // StringBuf - a way to keep string memory operations to a minimum
 // while building the strings for the xml files
-var StringBuf = module.exports = function(options) {
+var StringBuf = module.exports = function() {
   this.reset();
 };
 

lib/utils/utils.js

@@ -45,7 +45,7 @@ var inherits = function(cls, superCtor, statics, prototype) {
 var utils = module.exports = {
   nop: function() {},
   promiseImmediate: function(value) {
-    return new PromishLib.Promish(function(resolve, reject) {
+    return new PromishLib.Promish(function(resolve) {
       if (global.setImmediate) {
         setImmediate(function() {
           resolve(value);
@@ -119,7 +119,7 @@ var utils = module.exports = {
 
   fs: {
     exists: function(path) {
-      return new PromishLib.Promish(function(resolve, reject) {
+      return new PromishLib.Promish(function(resolve) {
         fs.exists(path, function(exists) {
           resolve(exists);
         });

lib/xlsx/xform/base-xform.js

@@ -12,28 +12,28 @@ var PromishLib = require('../../utils/promish');
 var XmlStream = require('../../utils/xml-stream');
 
 // Base class for Xforms
-var BaseXform = module.exports = function(model, name) {
+var BaseXform = module.exports = function(/* model, name */) {
 };
 
 BaseXform.prototype = {
   // ============================================================
   // Virtual Interface
-  prepare: function(model, options) {
+  prepare: function(/* model, options */) {
     // optional preparation (mutation) of model so it is ready for write
   },
-  render: function(xmlStream, model) {
+  render: function(/* xmlStream, model */) {
     // convert model to xml
   },
-  parseOpen: function(node) {
+  parseOpen: function(/* node */) {
     // Sax Open Node event
   },
-  parseText: function(node) {
+  parseText: function(/* node */) {
     // Sax Text event
   },
-  parseClose: function(name) {
+  parseClose: function(/* name */) {
     // Sax Close Node event
   },
-  reconcile: function(model, options) {
+  reconcile: function(/* model, options */) {
     // optional post-parse step (opposite to prepare)
   },
 

lib/xlsx/xform/core/app-xform.js

@@ -14,12 +14,6 @@ var StringXform = require('../simple/string-xform');
 var AppHeadingPairsXform = require('./app-heading-pairs-xform');
 var AppTitleOfPartsXform = require('./app-titles-of-parts-xform');
 
-var props = {
-  company: 'Company',
-  manager: 'Manager',
-  worksheets: [{name: 'sheet1'}]
-};
-
 var AppXform = module.exports = function() {
   this.map = {
     'Company': new StringXform({tag: 'Company'}),

lib/xlsx/xform/drawing/blip-xform.js

@@ -8,7 +8,6 @@
 
 var utils = require('../../../utils/utils');
 var BaseXform = require('../base-xform');
-var IntegerXform = require('../simple/integer-xform');
 
 var BlipXform = module.exports = function() {
 };

lib/xlsx/xform/drawing/drawing-xform.js

@@ -6,8 +6,6 @@
 
 'use strict';
 
-var events = require('events');
-
 var utils = require('../../../utils/utils');
 var XmlStream = require('../../../utils/xml-stream');
 
@@ -28,7 +26,7 @@ utils.inherits(WorkSheetXform, BaseXform, {
 }, {
   get tag() { return 'xdr:wsDr'; },
 
-  prepare: function(model, options) {
+  prepare: function(model) {
     var twoCellAnchorXform = this.map['xdr:twoCellAnchor'];
     model.anchors.forEach(function(item, index) {
       twoCellAnchorXform.prepare(item, {index: index});

lib/xlsx/xform/drawing/pic-xform.js

@@ -15,7 +15,7 @@ var NvPicPrXform = require('./nv-pic-pr-xform');
 
 var spPrJSON = require('./sp-pr');
 
-var PicXform = module.exports = function(options) {
+var PicXform = module.exports = function() {
   this.map = {
     'xdr:nvPicPr': new NvPicPrXform(),
     'xdr:blipFill': new BlipFillXform(),

lib/xlsx/xform/drawing/two-cell-anchor-xform.js

@@ -6,7 +6,6 @@
 
 'use strict';
 
-var _ = require('../../../utils/under-dash');
 var utils = require('../../../utils/utils');
 var colCache = require('../../../utils/col-cache');
 var BaseXform = require('../base-xform');
@@ -44,8 +43,6 @@ utils.inherits(TwoCellAnchorXform, BaseXform, {
         row: range.bottom
       };
     } else {
-      // API specifies zero based coords
-      const { row, col } = model.range.tl;
       model.tl = model.range.tl;
       model.br = model.range.br;
     }

lib/xlsx/xform/sheet/cell-xform.js

@@ -10,7 +10,6 @@ var utils = require('../../../utils/utils');
 var BaseXform = require('../base-xform');
 
 var Enums = require('../../../doc/enums');
-var RelType = require('../../rel-type');
 var Range = require('../../../doc/range');