refactor code duplication

allanjoseph98 · Jan 4, 2024 · c82d0b6 · c82d0b6
1 parent f819f73
commit c82d0b6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/app/views/user/perfStat.scala b/app/views/user/perfStat.scala
@@ -53,14 +53,7 @@ object perfStat:
               )(viewTheGames())
             )
           ),
-          ratingChart.isDefined option div(cls := "rating-history-container")(
-            div(cls := "rating-history-container")(
-              div(cls := "time-selector-buttons"),
-              (spinner),
-              div(cls := "chart-container")(canvas(cls := "rating-history")),
-              div(id := "time-range-slider")
-            )
-          ),
+          ratingChart.isDefined option ratingHistoryContainer,
           div(cls := "box__pad perf-stat__content")(
             glicko(user, perfType, user.perfs(perfType), percentile),
             counter(stat.count),
@@ -73,6 +66,15 @@ object perfStat:
         )
       )
 
+  def ratingHistoryContainer = div(cls := "rating-history-container")(
+    div(cls := "rating-history-container")(
+      div(cls := "time-selector-buttons"),
+      spinner,
+      div(cls := "chart-container")(canvas(cls := "rating-history")),
+      div(id := "time-range-slider")
+    )
+  )
+
   private def decimal(v: Double) = lila.common.Maths.roundDownAt(v, 2)
 
   private def glicko(u: User, perfType: PerfType, perf: Perf, percentile: Option[Double])(using

diff --git a/app/views/user/show/header.scala b/app/views/user/show/header.scala
@@ -155,12 +155,7 @@ object header:
           val hideTroll = u.marks.troll && !ctx.is(u)
           div(id := "us_profile")(
             if info.ratingChart.isDefined && (!u.lame || ctx.is(u) || isGranted(_.UserModView)) then
-              div(cls := "rating-history-container")(
-                div(cls := "time-selector-buttons"),
-                (spinner),
-                div(cls := "chart-container")(canvas(cls := "rating-history")),
-                div(id := "time-range-slider")
-              )
+              views.html.user.perfStat.ratingHistoryContainer
             else (ctx.is(u) && u.count.game < 10) option newPlayer(u),
             div(cls := "profile-side")(
               div(cls := "user-infos")(