-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] Refined allure-js-commons #909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme:mocha
Mocha related issue
theme:jest
Jest related issue
theme:cucumberjs
CucumberJS related issue
theme:jasmine
Jasmine related issue
theme:decorators
theme:build
theme:playwright
theme:newman
theme:codeceptjs
theme:vitest
labels
Mar 21, 2024
3 tasks
epszaw
force-pushed
the
new-lifecycle
branch
3 times, most recently
from
April 8, 2024 12:41
392e047
to
369139e
Compare
This was referenced May 6, 2024
fix typescript errors add some minor change to lifecycle state class
fix retries test
update eslint script arguments for all packages update vitest tsconfig files
baev
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
theme:api
Javascript API related issue
theme:build
theme:codeceptjs
theme:cucumberjs
CucumberJS related issue
theme:decorators
theme:hermione
theme:jasmine
Jasmine related issue
theme:jest
Jest related issue
theme:mocha
Mocha related issue
theme:newman
theme:playwright
theme:vitest
theme:workflow
type:improvement
Improvement or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is major
allure-js-commons
refactoring. The main issue with the current implementation is that each integration provides its own Runtime API. So, it's impossible to create 2nd level integrations (e.g. allure-selenium or allure-axios). Besides, there is some inconsistency with the API's.The other issue is that commons used to be node-only. In the latest release, we added browser implementation. This PR will adopt it even further, completely replacing the old commons.
The goal of the change is to expose Runtime API from
allure-js-commons
:The code above will work in all the supported frameworks.
New Commons architecture:
TestRuntime
interface. Provides abstraction forallure-js-commons
. All the Runtime API will useTestRuntime
, exposed inglobalThis.allureTestRuntime
variable. Each integration needs to implement its ownTestRuntime
and ensure it is configured and set toglobalise
in every scope where Runtime API is supported (e.g. in worker threads in case of parallel execution).allure-js-commons
for async andallure-js-commons/sync
for sync alternatives).ReporterRuntime
(unified way to store Allure State), Writers, Crypro (node & browser), TestPlan, etc.Linked issues
fixes #801
All the issues that should be addressed in this PR: https://github.com/allure-framework/allure-js/milestone/1
Checklist