Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the local docker development experience #107

Merged
merged 17 commits into from
Jun 6, 2024

Conversation

gdraynz
Copy link
Contributor

@gdraynz gdraynz commented May 24, 2024

This PR fixes the local Docker usage with updated task tasks (instead of make rules).
The previous Dockerfile was not functional at all due to very outdated software versions.

To test:

task 5.6:tests
task 5.6:shell
task 7.2:tests
task lint  # Should default to latest PHP version, right now 8.3

We also do a better job at zipping the dist build, with just what is needed inside:

task build

Result is a ZIP containing:

├── src
│  ├── Endpoints
│  ├── Entities
│  ├── Exceptions
│  ├── Lib
│  ├── Payloads
│  ├── Client.php
│  ├── ClientContext.php
│  ├── DependenciesError.php
│  ├── PaginatedResults.php
│  ├── ParamsError.php
│  ├── Request.php
│  ├── RequestError.php
│  └── Response.php
├── CHANGELOG.md
├── composer.json
├── LICENSE
└── README.md

Dockerfile Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@gdraynz gdraynz force-pushed the devx/dex-860-docker-environment branch from eae6d06 to 5d0a62c Compare May 24, 2024 15:06
@gdraynz gdraynz changed the title Update the docker local development experience Update the local docker development experience May 24, 2024
@gdraynz gdraynz requested a review from a team May 24, 2024 15:25
@gdraynz gdraynz marked this pull request as ready for review May 24, 2024 15:25
@gdraynz gdraynz marked this pull request as draft May 24, 2024 15:52
@gdraynz gdraynz requested a review from a team June 4, 2024 13:00
@gdraynz gdraynz marked this pull request as ready for review June 4, 2024 13:00
alma-renovate-bot bot and others added 3 commits June 4, 2024 15:33
Co-authored-by: alma-renovate-bot[bot] <163289924+alma-renovate-bot[bot]@users.noreply.github.com>
* Run CI on multiple PHP versions

* Remove fail-fast strategy

* Add more PHP versions

* Setup configuration file depending on the PHP version used

* Use proper ci phpunit xml file

* Revert change in phpunit.dist.legacy.xml
@gdraynz gdraynz force-pushed the devx/dex-860-docker-environment branch from 11173b1 to bc6e78d Compare June 4, 2024 13:34
@gdraynz gdraynz marked this pull request as draft June 5, 2024 12:21
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gdraynz gdraynz marked this pull request as ready for review June 5, 2024 14:30
@gdraynz gdraynz merged commit 80a0ec6 into develop Jun 6, 2024
3 of 12 checks passed
@Francois-Gomis Francois-Gomis deleted the devx/dex-860-docker-environment branch July 11, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants