-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the local docker development experience #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdraynz
force-pushed
the
devx/dex-860-docker-environment
branch
from
May 24, 2024 15:06
eae6d06
to
5d0a62c
Compare
gdraynz
changed the title
Update the docker local development experience
Update the local docker development experience
May 24, 2024
Co-authored-by: alma-renovate-bot[bot] <163289924+alma-renovate-bot[bot]@users.noreply.github.com>
* Run CI on multiple PHP versions * Remove fail-fast strategy * Add more PHP versions * Setup configuration file depending on the PHP version used * Use proper ci phpunit xml file * Revert change in phpunit.dist.legacy.xml
gdraynz
force-pushed
the
devx/dex-860-docker-environment
branch
from
June 4, 2024 13:34
11173b1
to
bc6e78d
Compare
Quality Gate passedIssues Measures |
joyet-simon
approved these changes
Jun 5, 2024
remi-zuffinetti
approved these changes
Jun 6, 2024
carine-bonnafous
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the local Docker usage with updated
task
tasks (instead ofmake
rules).The previous Dockerfile was not functional at all due to very outdated software versions.
To test:
task 5.6:tests task 5.6:shell task 7.2:tests task lint # Should default to latest PHP version, right now 8.3
We also do a better job at zipping the dist build, with just what is needed inside:
Result is a ZIP containing: