Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests #110

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Conversation

joyet-simon
Copy link
Contributor

Reason for change

ClickUp task

Code changes

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon changed the base branch from main to develop June 7, 2024 08:28
@joyet-simon joyet-simon marked this pull request as ready for review June 17, 2024 15:30
@joyet-simon joyet-simon force-pushed the feature/ecom-1763-improve-unit-tests branch from 7155b69 to 2eab883 Compare June 17, 2024 15:31
Copy link
Collaborator

@Francois-Gomis Francois-Gomis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't corrected the tests, I think we need to review the use of mockery

.DS_Store Outdated Show resolved Hide resolved
src/Endpoints/Orders.php Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@joyet-simon joyet-simon merged commit 9481a0b into develop Jun 24, 2024
2 of 12 checks passed
@joyet-simon joyet-simon deleted the feature/ecom-1763-improve-unit-tests branch June 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants