Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX] Fix release zip filename #117

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[DEVX] Fix release zip filename #117

merged 1 commit into from
Jul 4, 2024

Conversation

carine-bonnafous
Copy link
Contributor

Reason for change

task dist command results in the creation of the file dist/alma-php-client.zip
But in the release publish workflow, we are adding a file dist/alma.zip to the Github release.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@carine-bonnafous carine-bonnafous marked this pull request as ready for review July 4, 2024 07:11
@carine-bonnafous carine-bonnafous requested a review from a team as a code owner July 4, 2024 07:11
@carine-bonnafous carine-bonnafous merged commit f4eeb80 into develop Jul 4, 2024
3 of 12 checks passed
@Francois-Gomis Francois-Gomis deleted the devx/fix-dist-filename branch July 11, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-zuffinetti remi-zuffinetti remi-zuffinetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carine-bonnafous @remi-zuffinetti