-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release workflow and unit tests improvement into main #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: alma-renovate-bot[bot] <163289924+alma-renovate-bot[bot]@users.noreply.github.com>
* Run CI on multiple PHP versions * Remove fail-fast strategy * Add more PHP versions * Setup configuration file depending on the PHP version used * Use proper ci phpunit xml file * Revert change in phpunit.dist.legacy.xml
Improve unit tests
[DEX-889] Add new release workflow
[DEVX] Fix release zip filename
…nges in changelog
[DEVX] Fix branch for release-drafter + don't publish internal changes in changelog
Quality Gate failedFailed conditions |
carine-bonnafous
changed the title
Develop
Merge release workflow and unit tests improvement into main
Jul 9, 2024
I close this for the benefit of #120 as there are conflicts to resolve, and I don't want to push changes directly in develop branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
We need to merge
develop
intomain
to be able to use the new release workflowI wanted to cherry-pick commits but there is too many interconnected changes in many PRs, so it is more simple to merge develop into main, as there are only internal changes.
Warning
I see that the file
src/Endpoints/Orders.php
is changed, so it means that there is not only internal changes. Can this be an issue ? It has been changed in the PR to update unit tests