Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release workflow and unit tests improvement into main #119

Closed
wants to merge 16 commits into from

Conversation

carine-bonnafous
Copy link
Contributor

@carine-bonnafous carine-bonnafous commented Jul 9, 2024

Reason for change

We need to merge develop into main to be able to use the new release workflow
I wanted to cherry-pick commits but there is too many interconnected changes in many PRs, so it is more simple to merge develop into main, as there are only internal changes.

Warning

I see that the file src/Endpoints/Orders.php is changed, so it means that there is not only internal changes. Can this be an issue ? It has been changed in the PR to update unit tests

alma-renovate-bot bot and others added 16 commits June 3, 2024 10:15
Co-authored-by: alma-renovate-bot[bot] <163289924+alma-renovate-bot[bot]@users.noreply.github.com>
* Run CI on multiple PHP versions

* Remove fail-fast strategy

* Add more PHP versions

* Setup configuration file depending on the PHP version used

* Use proper ci phpunit xml file

* Revert change in phpunit.dist.legacy.xml
[DEVX] Fix branch for release-drafter + don't publish internal changes in changelog
Copy link

sonarqubecloud bot commented Jul 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@carine-bonnafous carine-bonnafous changed the title Develop Merge release workflow and unit tests improvement into main Jul 9, 2024
@carine-bonnafous
Copy link
Contributor Author

I close this for the benefit of #120 as there are conflicts to resolve, and I don't want to push changes directly in develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants