Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callbackUrl #66

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Add callbackUrl #66

merged 6 commits into from
Feb 1, 2024

Conversation

ClaireAlma
Copy link
Contributor

Reason for change

Send cancel url in subscription data

ClickUp task

@ClaireAlma ClaireAlma self-assigned this Jan 25, 2024
@ClaireAlma ClaireAlma marked this pull request as draft January 30, 2024 14:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClaireAlma ClaireAlma marked this pull request as ready for review February 1, 2024 12:11
@ClaireAlma ClaireAlma changed the title Add cancelUrl Add callbackUrl Feb 1, 2024
@ClaireAlma ClaireAlma merged commit f271169 into main Feb 1, 2024
2 checks passed
@ClaireAlma ClaireAlma deleted the feature/ECOM-1260/php-client-send-cancel-url branch February 1, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma Benjamin-Freoua-Alma approved these changes

@Francois-Gomis Francois-Gomis Awaiting requested review from Francois-Gomis

@FranceBe FranceBe Awaiting requested review from FranceBe

@joyet-simon joyet-simon Awaiting requested review from joyet-simon

Assignees

@ClaireAlma ClaireAlma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ClaireAlma @joyet-simon @Benjamin-Freoua-Alma @Francois-Gomis