Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security update sfcc node version #141

Merged

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Linear task

Code changes

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested review from a team as code owners November 25, 2024 15:31
.github/workflows/aqua.yml Outdated Show resolved Hide resolved
@FranceBe FranceBe force-pushed the feature/ecom-2016-security-update-sfcc-node-version-bis branch from 53db7cb to e5302e4 Compare November 26, 2024 11:20
@FranceBe FranceBe changed the title Security update sfcc node version bis Security update sfcc node version Nov 26, 2024
@FranceBe
Copy link
Contributor

Hi @gdraynz ,
We changed node version, but I don't get where this CI check is coming from ?
I don't see any other reference to node 12 in the repo, what am I missing ? :(

Capture d’écran 2024-11-26 à 12 40 10

Copy link
Contributor

@gdraynz gdraynz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required check is in the branch protection rules, I will do the swap.

@gdraynz
Copy link
Contributor

gdraynz commented Nov 28, 2024

@FranceBe Done, sorry I thought I did earlier 😁

@joyet-simon joyet-simon merged commit 3a90b0a into develop Nov 29, 2024
3 checks passed
@joyet-simon joyet-simon deleted the feature/ecom-2016-security-update-sfcc-node-version-bis branch November 29, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants