Update world taxon rake #1883
Merged
Update world taxon rake #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellohez
force-pushed
the
update-world-taxon-rake
branch
7 times, most recently
from
4ff3b24 to
658f345
Compare
baisa
reviewed
Dec 20, 2024
lib/tasks/world_taxon_update.rake
Outdated
| # (common ancestor e.g. /world/all - Help and services around the world) as the root | ||
| taxonomy = Taxonomy::ExpandedTaxonomy.new(ROOT_CONTENT_ID).build.child_expansion | ||
| log_file&.puts("Taxonomy has size #{taxonomy.tree.size}") | ||
| puts("Taxonomy has size #{taxonomy.tree.size}") |
There was a problem hiding this comment.
Consider refactoring this bit of a code (and similar occurrences below)
log_file&.puts(message)
puts(message)
into method to avoid duplications
baisa
reviewed
Dec 20, 2024
lib/tasks/world_taxon_update.rake
Outdated
| new_title = internal_name.gsub("(", "in ") | ||
| end | ||
| new_title.gsub!(")", "") | ||
| log_file ? log_file.puts(message) : puts(message) |
There was a problem hiding this comment.
Consider moving "new title" building code into separate method, too. It could be something like below, using case statement for more clarity.
def create_new_title(internal_name)
case internal_name
when ....
baisa
reviewed
Dec 20, 2024
lib/tasks/world_taxon_update.rake
Outdated
| message = "Skipping #{internal_name} as it already includes the country name" | ||
| log_file ? log_file.puts(message) : puts(message) | ||
| next | ||
| end |
There was a problem hiding this comment.
Could we take lines 31, and 42-45 into one separate conditional method we can call in line 31, something like:
next if skip_item?(linked_item). We will only need to remember to use linked_item.internal_name as internal_name will be defined later
ellohez
force-pushed
the
update-world-taxon-rake
branch
3 times, most recently
from
8d5bc0e to
f8e243b
Compare
- Log errors to stdout AND log file - DRY out code by creating methods for: - Logging, creating the new title and testing if the current taxon should be skipped
ellohez
force-pushed
the
update-world-taxon-rake
branch
from
f8e243b to
6d37275
Compare
baisa
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rake task was created to update the world taxonomy titles to include the name of the country which the page relates to. This is achieved by copying the name of the country from the internal name.
Included is a rake task to revert the taxon titles to their previous state by removing the country name which is useful for testing the task on Integration.
As some of the titles already include the name of the country, these are skipped, as are the root taxon and any taxons for GENERIC template pages as these do not relate to a specific country.
See the Trello Card for information on why this is necessary to meet WCAG (accessibility guidelines).
Example test log output:
Screenshot
Worldwide taxonomy on Content tagger