Skip to content

Commit

Permalink
Merge pull request #63 from alphagov/Adding-issues-to-components
Browse files Browse the repository at this point in the history
Added issues log to content list and breacrumbs pages
  • Loading branch information
ChristineWuerth authored Oct 9, 2024
2 parents 7675e46 + 7943d95 commit d856518
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 6 deletions.
16 changes: 14 additions & 2 deletions docs/components/breadcrumbs.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,20 @@ issues:
# To add additional issues duplicate the the fields below (adhering to the formating) but increase the count by one integer.
0:
# Both title and link are REQUIRED in order to display this information on the page.
title: #Delete this comment before entering the title of the GitHub issue.
link: #Delete this comment before entering the URL of the corresponding GitHub issue.
title: Breadcrumbs don't show the page you are on. Is that a problem?
link: https://github.com/alphagov/govuk_publishing_components/issues/4257
1:
# Both title and link are REQUIRED in order to display this information on the page.
title: We can’t give specialist document finders a parent taxonomy topic, because there’s no route back.
link: https://github.com/alphagov/govuk_publishing_components/issues/4258
2:
# Both title and link are REQUIRED in order to display this information on the page.
title: Parts or all of breadcrumbs missing on some pages
link: https://github.com/alphagov/govuk_publishing_components/issues/4259
3:
# Both title and link are REQUIRED in order to display this information on the page.
title: When content is tagged to multiple topics the breadcrumb component selects one in alphabetical order. Are there alternatives that would work better for users?
link: https://github.com/alphagov/govuk_publishing_components/issues/4260


# Kati's additional suggestions
Expand Down
21 changes: 19 additions & 2 deletions docs/components/content-list.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,23 @@ issues:
# To add additional issues duplicate the the fields below (adhering to the formating) but increase the count by one integer.
0:
# Both title and link are REQUIRED in order to display this information on the page.
title: #Delete this comment before entering the title of the GitHub issue.
link: #Delete this comment before entering the URL of the corresponding GitHub issue.
title: There is no visual differentiation between navigating within a page and across pages.
link: https://github.com/alphagov/govuk_publishing_components/issues/4261
1:
# Both title and link are REQUIRED in order to display this information on the page.
title: The components gives very low visibility of which page in a list is active.
link: https://github.com/alphagov/govuk_publishing_components/issues/4262
2:
# Both title and link are REQUIRED in order to display this information on the page.
title: The contents list is too low in the type hierarchy.
link: https://github.com/alphagov/govuk_publishing_components/issues/4263
3:
# Both title and link are REQUIRED in order to display this information on the page.
title: The m-dash is unusual as a visual marker on gov.uk.
link: https://github.com/alphagov/govuk_publishing_components/issues/4264
4:
# Both title and link are REQUIRED in order to display this information on the page.
title: Inconsistent position in source order
link: https://github.com/alphagov/govuk_publishing_components/issues/4265

---
12 changes: 10 additions & 2 deletions docs/components/print-link.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ issues:
# To add additional issues duplicate the the fields below (adhering to the formating) but increase the count by one integer.
0:
# Both title and link are REQUIRED in order to display this information on the page.
title: #Delete this comment before entering the title of the GitHub issue.
link: #Delete this comment before entering the URL of the corresponding GitHub issue.
title: Not all pages display the print link.
link: https://github.com/alphagov/govuk_publishing_components/issues/4266
1:
# Both title and link are REQUIRED in order to display this information on the page.
title: Where print link is repeated at the top and bottom of a page the lock-up is currently inconsistent.
link: https://github.com/alphagov/govuk_publishing_components/issues/4267
2:
# Both title and link are REQUIRED in order to display this information on the page.
title: In dark mode the icon is not visible.
link: https://github.com/alphagov/govuk_publishing_components/issues/4268
---

0 comments on commit d856518

Please sign in to comment.