Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING Use component wrapper on attachment component #4545

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jan 14, 2025

What

  • Adds the component wrapper to the attachment component
  • This is a breaking change, as it renames data_attributes to url_data_attributes, as those data attributes were being used on a child component - data_attributes is now for data attributes applied to the parent HTML element.
  • This should only affect two templates - 1 and 2 which I verified using this search criteria.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

1 example has had its titled changed.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4545 January 14, 2025 09:52 Inactive
@AshGDS AshGDS force-pushed the attachment-component-wrapper branch from b9f5f3d to dbf53cd Compare January 14, 2025 09:56
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4545 January 14, 2025 09:57 Inactive
@AshGDS AshGDS force-pushed the attachment-component-wrapper branch from dbf53cd to bd09733 Compare January 14, 2025 10:43
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4545 January 14, 2025 10:43 Inactive
@AshGDS AshGDS force-pushed the attachment-component-wrapper branch from bd09733 to 107550b Compare January 14, 2025 13:34
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4545 January 14, 2025 13:34 Inactive
@AshGDS AshGDS force-pushed the attachment-component-wrapper branch from 107550b to 109b1c2 Compare January 14, 2025 13:39
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4545 January 14, 2025 13:39 Inactive
@AshGDS AshGDS requested a review from andysellick January 14, 2025 14:06
@AshGDS AshGDS merged commit 01b2db6 into main Jan 14, 2025
12 checks passed
@AshGDS AshGDS deleted the attachment-component-wrapper branch January 14, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants