Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING Use component wrapper on attachment link component #4549

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jan 14, 2025

What

  • Adds the component wrapper to the attachment component
  • This is a breaking change, as it renames data_attributes to url_data_attributes, as those data attributes were being used on a child component - data_attributes is now for data attributes applied to the parent HTML element.
  • This should only affect one template which I verified using this search criteria.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

1 example has had its titled changed.

@AshGDS AshGDS self-assigned this Jan 14, 2025
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4549 January 14, 2025 15:05 Inactive
@AshGDS AshGDS force-pushed the attachment-link-component-wrapper branch from 144ca5d to 07fdd26 Compare January 14, 2025 15:09
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4549 January 14, 2025 15:09 Inactive
@AshGDS AshGDS requested a review from andysellick January 14, 2025 15:14
@AshGDS AshGDS force-pushed the attachment-link-component-wrapper branch from 07fdd26 to 9e9a5b5 Compare January 15, 2025 09:52
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4549 January 15, 2025 09:53 Inactive
@AshGDS AshGDS merged commit 4043e62 into main Jan 15, 2025
12 checks passed
@AshGDS AshGDS deleted the attachment-link-component-wrapper branch January 15, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants