Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING Use component wrapper on big number component #4550

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jan 14, 2025

What

  • Adds the component wrapper to the big number component
  • This is a breaking change, as it renames data_attributes to nested_data_attributes, as those data attributes were being used on a child component - data_attributes is now for data attributes applied to the parent HTML element. I went with the name nested_data_attributes as it can either be on a span or a tag depending on what is passed to the component.
  • This should only affect two templates which I verified using this search criteria.
  • Also fixes some incorrect documentation, and removes the shared helper as the component wrapper now handles margin_bottom values.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

Examples have some description changes.

@AshGDS AshGDS self-assigned this Jan 14, 2025
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4550 January 14, 2025 15:59 Inactive
Also fixes some incorrect documentation, and removes the shared helper as the component wrapper now handles margin_bottom values.
@AshGDS AshGDS force-pushed the big-number-component-wrapper branch from f592611 to bfb0d8e Compare January 14, 2025 16:10
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4550 January 14, 2025 16:10 Inactive
@AshGDS AshGDS requested a review from andysellick January 14, 2025 16:14
@AshGDS AshGDS merged commit ed19497 into main Jan 15, 2025
12 checks passed
@AshGDS AshGDS deleted the big-number-component-wrapper branch January 15, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants