Fix component wrapper rel option #4552
Merged
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AshGDS pause on review of this - just realised I can improve the test coverage. |
- code previously assumed that only one rel option would be passed, but you can have more than one in the attribute - passing more than one previously caused an error even if all of the rels were valid, this change corrects that
andysellick
force-pushed
the
cw-rel-fix
branch
from
27c52d1 to
4240110
Compare
|
@AshGDS okay for review now whenever you're free 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a bug in how the component wrapper handles the
reloption.Why
Because I didn't think of this when I was writing it yesterday 🤦
Visual Changes
None.
Trello card: https://trello.com/c/hUDC8lzz/418-add-component-wrapper-helper-to-button-component