Add configuration to "Add another" #4575
Conversation
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
f172a68 to
865981f
Compare
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
b78db53 to
547f2d8
Compare
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
547f2d8 to
b9bfd0c
Compare
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
27b3638 to
d1b963a
Compare
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
d1b963a to
e2013b6
Compare
davidtrussler
changed the title
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
e2013b6 to
8f7893b
Compare
| <%= item[:destroy_checkbox] %> | ||
| </div> | ||
| <%= item[:fields] %> | ||
| <div data-module="add-another" class="gem-c-add-another" data-add-button-text="<%= add_button_text %>" data-fieldset-legend="<%= fieldset_legend %>" data-empty-fields="<%= empty_fields %>"> |
There was a problem hiding this comment.
I think at this point it may be better to use the built in Rails tag.div syntax for adding data attributes e.g. <%= tag.div class: "classes", data: { fieldset_legend: "etc" } do %>
| render_component({ items: default_items, empty_fields: true }) | ||
|
|
||
| assert_select "div[data-module='add-another'][data-empty-fields='true']" | ||
| end |
There was a problem hiding this comment.
Does the behaviour need to be tested e.g. it renders the empty state correctly?
There was a problem hiding this comment.
Good point: I've updated these tests a bit to duplicate and change them for the "Default" and "Start empty" options, which is probably the clearest way to present what it being tested.
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
8f7893b to
dba9a8c
Compare
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
321a551 to
09a891c
Compare
Thanks @AshGDS - I've made a couple of updates in resonse to your queries if you'd be able to hae another quick look:
|
| module: "add-another", | ||
| "add-button-text": add_button_text, | ||
| "fieldset-legend": fieldset_legend, | ||
| "empty-fields": empty_fields |
There was a problem hiding this comment.
I think you can forgo using strings as Ruby would convert underscores to hyphens (e.g. add_button_text would become data-add-button-text, but this isn't a massive issue of course so feel free to leave it!
- Add new "start_empty" option to component doc - Hidden class on "Delete" button added conditionaly on `empty-fields` data attribute - Add `empty-fields` data-attribute to view - Update JS test - Update RSpec test - Update CHANGELOG
davidtrussler
force-pushed
the
4564_Add-another-Configure-delete
branch
from
09a891c to
95f291a
Compare
What
Publishing Components Issue #4564
This adds some configuration to the "Add another" component so that authors can choose how the component displays by default when it is rendered on a page and no content is provided to it.
Why
The current default behaviour of the "Add another" component when it loads is to:
There is a need to customise this behaviour for these scenarios when it is implemented on the Mainstream publisher app so that:
Visual Changes
The screenshots below show the component implemented on Mainstream Publisher as it currently displays and how it is displayed with these changes.