Add another: fix problem in createRemoveButtons method:
#4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtrussler
force-pushed
the
Fix-createRemoveButtons-method
branch
from
a6fdfec to
5bea69c
Compare
AshGDS
approved these changes
Jan 27, 2025
davidtrussler
force-pushed
the
Fix-createRemoveButtons-method
branch
from
5bea69c to
e7a0f2c
Compare
- This creates multiple "Delete" buttons
davidtrussler
force-pushed
the
Fix-createRemoveButtons-method
branch
from
e7a0f2c to
792ce10
Compare
Hello @AshGDS Thanks for the review and yes, good spot, there is an error that should probably be looked at. I'll raise an issue separately. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change updates a
querySelectorAllcall to be made on the module rather than the document.Why
As it is this creates multiple "Delete" buttons if there are more than one instance of the component on the page (i.e. one per instance).