Replace title component with heading #4591
Merged
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- title component is redundant and is being replaced with the heading component - visually identical
AshGDS
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replaces the H1s rendered in the component guide by the title component with H1s rendered using the heading component.
Probably no need for a changelog entry as this is an internal change to the component guide.
Why
These title components used the margin top option, which we're trying to remove (moving towards a world where components only have bottom margin).
Additionally we're trying to retire the title component, as the same functionality is provided by the heading component.
Visual Changes
None.
Trello card: https://trello.com/c/Y0pDWbHw/390-remove-margintop-option-from-shared-helper