Merge pull request #1107 from alphagov/dependabot/bundler/rubocop-gov…

…uk-5.0.8

Bump rubocop-govuk from 5.0.7 to 5.0.8

Gemfile.lock

@@ -524,7 +524,7 @@ GEM
       term-ansicolor (~> 1.7)
       thor (>= 0.20, < 2.0)
     parallel (1.26.3)
-    parser (3.3.6.0)
+    parser (3.3.7.0)
       ast (~> 2.4.1)
       racc
     parslet (2.0.0)
@@ -635,7 +635,7 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.2)
-    rubocop (1.69.2)
+    rubocop (1.70.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
@@ -649,8 +649,8 @@ GEM
       parser (>= 3.3.1.0)
     rubocop-capybara (2.21.0)
       rubocop (~> 1.41)
-    rubocop-govuk (5.0.7)
-      rubocop (= 1.69.2)
+    rubocop-govuk (5.0.8)
+      rubocop (= 1.70.0)
       rubocop-ast (= 1.37.0)
       rubocop-capybara (= 2.21.0)
       rubocop-rails (= 2.28.0)
@@ -710,7 +710,7 @@ GEM
       sync
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.3)
+    unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
     uri (0.13.1)

app/controllers/anonymous_feedback/problem_reports_controller.rb

@@ -74,13 +74,9 @@ def mark_supplied_reports_as_reviewed_and_spam
 
         review_attrs = { reviewed: true, marked_as_spam: }
 
-        if problem_report.update(review_attrs)
-          true
-        else
-          false
-        end
+        problem_report.update!(review_attrs)
       end
-    rescue ActiveRecord::RecordNotFound
+    rescue ActiveRecord::RecordNotFound, ActiveRecord::RecordInvalid
       false
     end