Topology: NHLT: Intel: Fix mono DMIC configure for MTL platform #286
+20
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
commented
Jan 9, 2025
| @@ -818,19 +828,13 @@ static int configure_registers(struct intel_dmic_params *dmic, struct dmic_calc_ | |||
| OUTCONTROL1_IPM_SOURCE_2(source[1]) | | |||
| OUTCONTROL1_IPM_SOURCE_3(source[2]) | | |||
| OUTCONTROL1_IPM_SOURCE_4(source[3]) | | |||
| OUTCONTROL1_IPM_SOURCE_MODE(1) | | |||
| OUTCONTROL1_IPM_SOURCE_MODE(ipmsm) | | |||
There was a problem hiding this comment.
I need to change this, it's not currently an utilized feature but the microphones/channels for dmic0 and dmic1 are not necessarily the same. Should determine two values ipmsm0 and ipmsm1.
This change fixes the blob generator for mono microphone configuration. As difference to previous platforms the FIFO packer mono/stereo mode set up in OUTCONTROLx IPM_SOURCE_MODE bit-field. The previous code version hard-codes the FIFO packer to stereo mode without support for mono. As a fix if only one microphone is enabled for dmic0 or dmic1, then the corresponding IPM_SOURCE_MODE in OUTCONTROL0 or OUTCONTROL1 is set to 0. Otherwise it is set to 1 for stereo mode. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
intel_ace_mono_dmic_fix
branch
from
0162116 to
d94ed97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the blob generator for mono microphone configuration. As difference to previous platforms the FIFO packer mono/stereo mode set up in OUTCONTROLx IPM_SOURCE_MODE bit-field.