remove already_associated variable #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencersevilla
added a commit
that referenced
this pull request
Jan 4, 2024
This reverts commit 2e0e4c6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The already_associated variable was used to reduce chatter, in that the first time the CPS associates with a UPS, it will not ask it to delete all sessions. HOWEVER this did not take into account the situation wherein the CPS crashes and re-associates with a UPS, in which case the CPS thinks it's the first association but the UPS still has some "ghost" sessions that can linger and cause signaling issues. Thus we need to always send the reset message when we join just to make sure we're working with a clean slate.