-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update lint package dependencies and integrate custom linting across packages #111
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
include: package:altive_lints/altive_lints.yaml | ||
analyzer: | ||
plugins: | ||
- custom_lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 20 additions & 14 deletions
34
packages/altfire_authenticator/lib/src/authenticatable.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,36 @@ | ||
import 'package:firebase_auth/firebase_auth.dart'; | ||
|
||
/// Interface for authenticatable classes. | ||
/// | ||
/// This interface defines the methods required for authentication operations | ||
/// such as sign-in, reauthentication, linking, and unlinking. | ||
/// | ||
/// Implementing classes should provide concrete implementations for methods. | ||
abstract class Authenticatable { | ||
/// すでにサインイン済みかどうか。 | ||
/// Whether the user is already signed in. | ||
bool get alreadySigned; | ||
|
||
/// サインイン。 | ||
/// Signs in the user. | ||
/// | ||
/// 電話番号認証ではサインイン処理が2STEPに分かれており、 | ||
/// [AuthCredential]を外から渡す必要があるため、 | ||
/// オプショナル引数として[AuthCredential]を受け取る形にしている。 | ||
/// For phone number authentication, the sign-in process is divided into | ||
/// two steps, and an [AuthCredential] needs to be provided from outside. | ||
/// Therefore, it is accepted as an optional argument. | ||
Future<UserCredential> signIn([AuthCredential? credential]); | ||
|
||
/// 再認証する。 | ||
/// Reauthenticates the user. | ||
/// | ||
/// 電話番号認証ではサインイン処理が2STEPに分かれており、 | ||
/// [AuthCredential]を外から渡す必要があるため、 | ||
/// オプショナル引数として[AuthCredential]を受け取る形にしている。 | ||
/// For phone number authentication, the reauthentication process is divided | ||
/// into two steps, and an [AuthCredential] needs to be provided from outside. | ||
/// Therefore, it is accepted as an optional argument. | ||
Future<UserCredential> reauthenticate([AuthCredential? credential]); | ||
|
||
/// ユーザーにAppleを紐付ける。 | ||
/// Links the user with an Apple account. | ||
/// | ||
/// 電話番号認証ではサインイン処理が2STEPに分かれており、 | ||
/// [AuthCredential]を外から渡す必要があるため、 | ||
/// オプショナル引数として[AuthCredential]を受け取る形にしている。 | ||
/// For phone number authentication, the linking process is divided into | ||
/// two steps, and an [AuthCredential] needs to be provided from outside. | ||
/// Therefore, it is accepted as an optional argument. | ||
Future<UserCredential> link([AuthCredential? credential]); | ||
|
||
/// Apple IDをリンク解除。 | ||
/// Unlinks the user's Apple ID. | ||
Future<User> unlink(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
include: package:altive_lints/altive_lints.yaml | ||
analyzer: | ||
plugins: | ||
- custom_lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it a private variable to match the other XxxAuthenticator, as it seemed to be used only internally!