Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add FlutterFireRemoteParameterFetcher example package #13

Merged
merged 9 commits into from
Nov 9, 2023

Conversation

riscait
Copy link
Member

@riscait riscait commented Nov 5, 2023

πŸ™Œ What I did

  • Added example package for FilterFireRemoteParameterFetcher

✍️ What I didn't do

  • fix Unsupported operation: onConfigUpdated is not supported for web

βœ… Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

iOS and Anrdoid

macos
image

Additional Information

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 5, 2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote how to create a new example package.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (3d5e2dc) 37.44% compared to head (b879969) 37.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   37.44%   37.44%           
=======================================
  Files           9        9           
  Lines         235      235           
=======================================
  Hits           88       88           
  Misses        147      147           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

.gitignore Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the flutterfire repository, these files were committed, so I copied them.

flutterfire configure
```

https://console.firebase.google.com/project/flutterfire-adapter
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already created a Firebase project using the fluttefire configure command.
https://console.firebase.google.com/project/flutterfire-adapter

@riscait riscait marked this pull request as ready for review November 5, 2023 02:29
@riscait riscait requested a review from naipaka as a code owner November 5, 2023 02:29
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for creating the example package!
I see, so onConfigUpdated can't be used on the web...

@riscait
Copy link
Member Author

riscait commented Nov 6, 2023

Created #14 for problems on the web.

Base automatically changed from publish-remote-parameter to main November 7, 2023 00:56
@riscait riscait merged commit e555827 into main Nov 9, 2023
6 checks passed
@riscait riscait deleted the add-example-app branch November 9, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants