feat: Add user changes stream #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 54.40% 54.40%
=======================================
Files 10 10
Lines 261 261
=======================================
Hits 142 142
Misses 119 119
☔ View full report in Codecov by Sentry. |
riscait
reviewed
Nov 12, 2023
| @@ -29,6 +29,9 @@ class Authenticator { | |||
| /// 現在サインイン中のユーザー。サインインしていない場合はnullを返す。 | |||
| User? get user => _auth.currentUser; | |||
|
|
|||
| /// Listens for changes to the currently signed-in user. | |||
| Stream<User?> get userChanges => _auth.userChanges(); | |||
There was a problem hiding this comment.
Is Getter better than late final here?
There was a problem hiding this comment.
Just like Configurator's onConfigUpdated, that approach is less likely to lead to unexpected behavior...!
When exposing a Stream, it's basically better to use late final. Thank you 🙏
riscait
reviewed
Nov 12, 2023
| @@ -14,6 +14,7 @@ void main() { | |||
| class MockAuth extends Fake implements FirebaseAuth {} | |||
|
|
|||
| // TODO(riscait): add more tests | |||
| // https://github.com/altive/flutterfire_adapter/issues/20 | |||
There was a problem hiding this comment.
Thanks for adding the Issue link!
naipaka
force-pushed
the
add-user-changes-stream
branch
from
3bcb7cf to
c5be867
Compare
|
I'll merge this for now! If there seems to be a problem, I'll fix it in a separate PR 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙌 What I did
✍️ What I didn't do
✅ Verification
Screenshots
Additional Information
I made it public because I wanted to use
userChanges!