Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add useEmulator method to Authenticator #23

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Nov 27, 2023

πŸ™Œ What I did

  • Add useEmulator method to Authenticator

✍️ What I didn't do

  • None

βœ… Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

Additional Information

@naipaka naipaka marked this pull request as ready for review November 27, 2023 02:43
@naipaka naipaka requested a review from riscait as a code owner November 27, 2023 02:43
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (414c785) 54.40% compared to head (d0701cb) 53.99%.

Files Patch % Lines
...utterfire_authenticator/lib/src/authenticator.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   54.40%   53.99%   -0.42%     
==========================================
  Files          10       10              
  Lines         261      263       +2     
==========================================
  Hits          142      142              
- Misses        119      121       +2     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@naipaka naipaka merged commit a016b46 into main Nov 27, 2023
5 of 7 checks passed
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naipaka naipaka deleted the enable-auth-emulator branch November 27, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants