Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flutterfire_notification package #25

Closed
wants to merge 1 commit into from

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Nov 30, 2023

🔗 Issue Link

closes #2

🙌 What I did

  • Add flutterfire_notification package

✍️ What I didn't do

✅ Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

Additional Information

@github-actions github-actions bot added documentation Improvements or additions to documentation test labels Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d23f430) 53.99% compared to head (41b4fe4) 54.47%.

Files Patch % Lines
...flutterfire_notification/lib/src/notification.dart 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   53.99%   54.47%   +0.48%     
==========================================
  Files          10       11       +1     
  Lines         263      268       +5     
==========================================
+ Hits          142      146       +4     
- Misses        121      122       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naipaka naipaka marked this pull request as ready for review November 30, 2023 03:34
@naipaka naipaka requested a review from riscait as a code owner November 30, 2023 03:34
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naipaka
Copy link
Contributor Author

naipaka commented Nov 30, 2023

Thank you for the review!
Sorry, but I am thinking of changing the package name and class name, so I will close this PR.

The main reason for the name change is that the class name 'Notification' conflicts with the Notification class of the standard Flutter package.

@naipaka naipaka closed this Nov 30, 2023
@naipaka naipaka deleted the 2-add-flutterfire-notification branch November 30, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a notification package for Cloud Messaging and flutter_local_notifications
2 participants