Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flutterfire_messenger package #27

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Nov 30, 2023

🔗 Issue Link

closes #2

🙌 What I did

  • Add flutterfire_messenger package

✍️ What I didn't do

✅ Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

Additional Information

@github-actions github-actions bot added documentation Improvements or additions to documentation test labels Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d23f430) 53.99% compared to head (e2b38f5) 54.47%.

Files Patch % Lines
...kages/flutterfire_messenger/lib/src/messenger.dart 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   53.99%   54.47%   +0.48%     
==========================================
  Files          10       11       +1     
  Lines         263      268       +5     
==========================================
+ Hits          142      146       +4     
- Misses        121      122       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naipaka naipaka force-pushed the 2-add-flutterfire-messenger branch from 601e453 to 297208a Compare November 30, 2023 05:30
@naipaka naipaka marked this pull request as ready for review November 30, 2023 05:32
@naipaka naipaka requested a review from riscait as a code owner November 30, 2023 05:32
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

badge

/// flutterfire_messenger with FlutterFire Messaging, Local Notifications,
/// In-App Messaging, and Firebase Installation ID.

It says "firebase_in_app_messaging", so it would be better to add firebase_in_app_messaging to pubspec's dependencies. (since I think just adding the package would give us the basic functionality of FIAM)

@naipaka
Copy link
Contributor Author

naipaka commented Nov 30, 2023

It says "firebase_in_app_messaging", so it would be better to add firebase_in_app_messaging to pubspec's dependencies. (since I think just adding the package would give us the basic functionality of FIAM)

Thank you for your review! Indeed, it seems like a good idea to add the firebase_in_app_messaging package. I will add it!

@naipaka naipaka merged commit 4d76320 into main Nov 30, 2023
6 checks passed
@naipaka naipaka deleted the 2-add-flutterfire-messenger branch November 30, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a notification package for Cloud Messaging and flutter_local_notifications
2 participants