Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Preparing to Publish FlutterFire Configurator on pub.dev #36

Merged
merged 5 commits into from
Dec 22, 2023

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Dec 22, 2023

πŸ”— Issue Link

#29

πŸ™Œ What I did

  • Update FlutterFire Configurator README
  • Add MIT License to project
  • Update pubspec.yaml

✍️ What I didn't do

None

βœ… Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

Additional Information

Please let me know if there are any other necessary files or descriptions needed πŸ™

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 22, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the LICENSE file from altive_lints.

@@ -0,0 +1 @@
../../LICENSE
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a symbolic link to the LICENSE file.

@naipaka naipaka marked this pull request as ready for review December 22, 2023 07:47
@naipaka naipaka requested a review from riscait as a code owner December 22, 2023 07:47
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (62f405a) 54.47% compared to head (bd2cbfe) 54.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   54.47%   54.47%           
=======================================
  Files          11       11           
  Lines         268      268           
=======================================
  Hits          146      146           
  Misses        122      122           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LICENSE Outdated Show resolved Hide resolved
@naipaka naipaka merged commit 67a6f5e into main Dec 22, 2023
6 checks passed
@naipaka naipaka deleted the 29-publish-flutterfire-configurator branch December 22, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants