Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create root example package (app) #62

Merged
merged 4 commits into from
Jan 24, 2024
Merged

docs: Create root example package (app) #62

merged 4 commits into from
Jan 24, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Jan 24, 2024

🔗 Issue Link

closes #61

🙌 What I did

  • add root example app with altfire packages

✍️ What I didn't do

  • Check the operation of each package using main.dart (primary purpose is to check dependencies)

✅ Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

iOS Android macOS Web (Chrome)
Simulator Screenshot - iPhone 15 Pro Max - 2024-01-24 at 14 30 26 share_6809793115731813695 Screenshot 2024-01-24 at 14 34 37 Screenshot 2024-01-24 at 14 35 25

Additional Information

@github-actions github-actions bot added documentation Improvements or additions to documentation test labels Jan 24, 2024
@riscait riscait changed the title Root-example docs: Create root example package (app) Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (94ee105) 54.27% compared to head (f0d1801) 57.62%.

Files Patch % Lines
example/lib/main.dart 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   54.27%   57.62%   +3.35%     
==========================================
  Files          11       12       +1     
  Lines         269      295      +26     
==========================================
+ Hits          146      170      +24     
- Misses        123      125       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,4 +1,4 @@
platform :osx, '10.14'
platform :osx, '10.15'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoogleSignIn must be 10.15 or higher.

@riscait
Copy link
Member Author

riscait commented Jan 24, 2024

Commit 72ab2b4 to run flutterfire configure and write the necessary statements to boot on Android.

@riscait
Copy link
Member Author

riscait commented Jan 24, 2024

Commit 7cafb09 write the necessary statements to boot on macOS.

@riscait riscait marked this pull request as ready for review January 24, 2024 05:46
@riscait riscait requested a review from a team as a code owner January 24, 2024 05:46
@riscait riscait requested review from k-nkmr and removed request for a team January 24, 2024 05:46
Comment on lines +9 to +21
dependencies:
altfire_authenticator: ^0.1.0
altfire_configurator: ^0.1.0
altfire_messenger: ^0.1.0
altfire_tracker: ^0.1.0
flutter:
sdk: flutter
meta: ^1.10.0

dev_dependencies:
altfire_lints: ^0.1.0
altive_lints: ^1.9.0
custom_lint: ^0.5.8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can install the published altfire package and check for dependencies.

Copy link
Contributor

@k-nkmr k-nkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait merged commit 8cb054f into main Jan 24, 2024
6 checks passed
@riscait riscait deleted the root-example branch January 24, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a root example package
2 participants