Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : Create an example package for altfire_messenger #70

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat : Create an example package for altfire_messenger #70

merged 1 commit into from
Feb 7, 2024
+5,385 −0

Conversation

k-nkmr
Copy link
Contributor

@k-nkmr k-nkmr commented Feb 7, 2024

🔗 Issue Link

closes #26

🙌 What I did

  • Added altfire_messenger_example

✍️ What I didn't do

  • None

✅ Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

iOS

Before Button Press After Button Press
Simulator Screenshot - iPhone 15 Plus - 2024-02-07 at 14 00 12 Simulator Screenshot - iPhone 15 Plus - 2024-02-07 at 14 02 09

Android

Before Button Press After Button Press
Screenshot_1707281865 Screenshot_1707281861

Additional Information

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 7, 2024
@k-nkmr k-nkmr marked this pull request as ready for review February 7, 2024 05:05
@k-nkmr k-nkmr requested a review from a team as a code owner February 7, 2024 05:05
@k-nkmr k-nkmr requested review from naipaka and removed request for a team February 7, 2024 05:05
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d332fbd) 58.19% compared to head (1040865) 58.19%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   58.19%   58.19%           
=======================================
  Files          13       13           
  Lines         299      299           
=======================================
  Hits          174      174           
  Misses        125      125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

naipaka
naipaka approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for adding the example!🚀

@k-nkmr k-nkmr merged commit 110297e into main Feb 7, 2024
7 checks passed
@k-nkmr k-nkmr deleted the 26-add-altfire-messenger-example branch February 7, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naipaka naipaka naipaka approved these changes

Assignees

@k-nkmr k-nkmr

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an example package for altfire_messenger
2 participants
@k-nkmr @naipaka