feat(authenticator): Extend fromError in AuthException #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-FirebaseAuthException types
naipaka
commented
Mar 18, 2024
| @@ -491,6 +491,30 @@ packages: | |||
| url: "https://pub.dev" | |||
| source: hosted | |||
| version: "4.8.1" | |||
| leak_tracker: | |||
There was a problem hiding this comment.
Updates made with melos bs✍️
Comment on lines
+6
to
+9
| factory AuthException.fromError(Object e) { | ||
| if (e is! FirebaseAuthException) { | ||
| return const AuthUndefinedError(); | ||
| } |
There was a problem hiding this comment.
To use the original AuthException.fromError, it was necessary to either:
- Expose
FirebaseAuthException - Allow receiving exceptions other than
FirebaseAuthException
So, I implemented it with the latter!
Comment on lines
-25
to
-28
| @override | ||
| String toString() => message; | ||
|
|
||
| String get message; |
There was a problem hiding this comment.
I have removed message as it is often desired to be set by the user!
| @@ -4,4 +4,4 @@ environment: | |||
| sdk: ^3.0.0 | |||
|
|
|||
| dev_dependencies: | |||
| melos: ^3.4.0 | |||
| melos: ^5.1.0 | |||
There was a problem hiding this comment.
Additionally, I updated to the latest version of melos
riscait
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙌 What I did
✍️ What I didn't do
✅ Verification
Screenshots
Additional Information