fix: No warnings in test directory (#70)

* fix: No warnings in test directory * doc: selfreview * doc:Add exclusion of _test.dart * doc: revise commit * doc: Delete test-related comments * fix: Changed from lint_test to test * fix: Change from test to lint_test * fix: Correction of directory location * fix: avoid_harded_color true * fix: selfreview * Update packages/altive_lints/example/test/avoid_hardcoded_japanese_test.dart Co-authored-by: Ryunosuke Muramatsu <[email protected]> * fix: Correction. --------- Co-authored-by: Ryunosuke Muramatsu <[email protected]>
altive · Oct 29, 2024 · 02d2fa8 · 02d2fa8
1 parent bce2f10
commit 02d2fa8
Show file tree

Hide file tree

Showing 16 changed files with 13 additions and 23 deletions.
diff --git a/packages/altive_lints/example/analysis_options.yaml b/packages/altive_lints/example/analysis_options.yaml
@@ -9,7 +9,3 @@ linter:
     # Disabled so that you don't have to write a doc since it is an `example`.
     - public_member_api_docs: false
 
-custom_lint:
-  rules:
-    # Disabled so that you can use hard-coded colors since it is an `example`.
-    - avoid_hardcoded_color: false
diff --git a/...id_consecutive_sliver_to_box_adapter.dart → ...id_consecutive_sliver_to_box_adapter.dart b/...id_consecutive_sliver_to_box_adapter.dart → ...id_consecutive_sliver_to_box_adapter.dart
diff --git a/...int_test/lints/avoid_hardcoded_color.dart → .../example/lints/avoid_hardcoded_color.dart b/...int_test/lints/avoid_hardcoded_color.dart → .../example/lints/avoid_hardcoded_color.dart
diff --git a/..._test/lints/avoid_hardcoded_japanese.dart → ...ample/lints/avoid_hardcoded_japanese.dart b/..._test/lints/avoid_hardcoded_japanese.dart → ...ample/lints/avoid_hardcoded_japanese.dart
diff --git a/.../lints/avoid_hardcoded_japanese_test.dart → .../lints/avoid_hardcoded_japanese_test.dart b/.../lints/avoid_hardcoded_japanese_test.dart → .../lints/avoid_hardcoded_japanese_test.dart
diff --git a/...lints/avoid_shrink_wrap_in_list_view.dart → ...lints/avoid_shrink_wrap_in_list_view.dart b/...lints/avoid_shrink_wrap_in_list_view.dart → ...lints/avoid_shrink_wrap_in_list_view.dart
diff --git a/...s/lint_test/lints/avoid_single_child.dart → ...nts/example/lints/avoid_single_child.dart b/...s/lint_test/lints/avoid_single_child.dart → ...nts/example/lints/avoid_single_child.dart
diff --git a/...nts/lint_test/lints/prefer_clock_now.dart → ...lints/example/lints/prefer_clock_now.dart b/...nts/lint_test/lints/prefer_clock_now.dart → ...lints/example/lints/prefer_clock_now.dart
diff --git a/...prefer_dedicated_media_query_methods.dart → ...prefer_dedicated_media_query_methods.dart b/...prefer_dedicated_media_query_methods.dart → ...prefer_dedicated_media_query_methods.dart
diff --git a/.../lints/prefer_space_between_elements.dart → .../lints/prefer_space_between_elements.dart b/.../lints/prefer_space_between_elements.dart → .../lints/prefer_space_between_elements.dart
diff --git a/...nts/prefer_to_include_sliver_in_name.dart → ...nts/prefer_to_include_sliver_in_name.dart b/...nts/prefer_to_include_sliver_in_name.dart → ...nts/prefer_to_include_sliver_in_name.dart
diff --git a/packages/altive_lints/example/pubspec.yaml b/packages/altive_lints/example/pubspec.yaml
@@ -12,4 +12,5 @@ dependencies:
 dev_dependencies:
   altive_lints:
     path: ../
+  clock: ^1.1.2
   custom_lint: ^0.6.5
diff --git a/packages/altive_lints/example/test/avoid_hardcoded_japanese_test.dart b/packages/altive_lints/example/test/avoid_hardcoded_japanese_test.dart
@@ -0,0 +1,9 @@
+// Check the `avoid_hardcoded_japanese` rule.
+//
+// It should exclude warnings for the entire `test` directory.
+
+const hiragana = 'あいうえお';
+
+const katakana = 'アイウエオ';
+
+const kanji = '漢字';
diff --git a/packages/altive_lints/lib/src/lints/avoid_hardcoded_japanese.dart b/packages/altive_lints/lib/src/lints/avoid_hardcoded_japanese.dart
@@ -40,6 +40,9 @@ class AvoidHardcodedJapanese extends DartLintRule {
     ErrorReporter reporter,
     CustomLintContext context,
   ) {
+    if (resolver.source.uri.pathSegments.contains('test')) {
+      return;
+    }
     if (resolver.source.shortName.endsWith('_test.dart')) {
       return;
     }

diff --git a/packages/altive_lints/lint_test/analysis_options.yaml b/packages/altive_lints/lint_test/analysis_options.yaml
diff --git a/packages/altive_lints/lint_test/pubspec.yaml b/packages/altive_lints/lint_test/pubspec.yaml