Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prefer_sliver_prefix rule #32

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Jul 29, 2024

🔗 Related Issues

  • None

🙌 What's Done

  • Add prefer_sliver_prefix rule

✍️ What's Not Done

  • None

🖼️ Image Differences

CleanShot 2024-07-29 at 18 04 32

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

This rule ensures that class names are consistent and easily recognizable as returning a Sliver widget!

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@naipaka naipaka marked this pull request as ready for review July 29, 2024 09:06
@naipaka naipaka requested a review from a team as a code owner July 29, 2024 09:06
@naipaka naipaka requested review from k-nkmr and removed request for a team July 29, 2024 09:06
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This is another great rule!

badge
Would a rule like "prefer_to_include_sliver_in_name" be better so that it is not limited to Prefix?
example: MyWidget.sliver() , MyExcellentViewWithSliver() , AltiveSliverWidget() .

@naipaka
Copy link
Contributor Author

naipaka commented Jul 29, 2024

@riscait

Would a rule like "prefer_to_include_sliver_in_name" be better so that it is not limited to Prefix?
example: MyWidget.sliver() , MyExcellentViewWithSliver() , AltiveSliverWidget() .

Indeed, having some flexibility might be beneficial✍️

Including the constructor could result in significant changes, so how about creating a separate improvement issue and having someone else handle it? 💭

@riscait
Copy link
Member

riscait commented Jul 29, 2024

Including the constructor could result in significant changes, so how about creating a separate improvement issue and having someone else handle it? 💭

Let's do that!

@naipaka
Copy link
Contributor Author

naipaka commented Jul 30, 2024

I created the following issue!
#36

@naipaka naipaka merged commit 6c941e7 into main Jul 30, 2024
1 check passed
@naipaka naipaka deleted the add-prefer-sliver-prefix branch July 30, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants