Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add prefer_dedicated_media_query_methods rule #34

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat: Add prefer_dedicated_media_query_methods rule #34

merged 2 commits into from
Jul 29, 2024

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Jul 29, 2024 •
edited
Loading

🔗 Related Issues

  • None

🙌 What's Done

  • Add prefer_dedicated_media_query_methods rule

✍️ What's Not Done

  • None

🖼️ Image Differences

CleanShot 2024-07-29 at 18 21 00

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@naipaka naipaka marked this pull request as ready for review July 29, 2024 09:23
@naipaka naipaka requested a review from a team as a code owner July 29, 2024 09:23
@naipaka naipaka requested review from riscait and removed request for a team July 29, 2024 09:23
riscait
riscait approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Great, that's a rule that I would like to have as a default!

@naipaka naipaka merged commit 945d5e8 into main Jul 29, 2024
1 check passed
@naipaka naipaka deleted the add-prefer-dedicated-media-query-methods branch July 29, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riscait riscait riscait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naipaka @riscait