Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decorator job with no inner function #1061

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

yitchen-tim
Copy link
Contributor

Description of changes:
Skip copying inner function source to decorator job when there is no inner function. The job interface did not handle empty input gracefully.

Testing done:
tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b533b89) to head (e550590).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1061   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines         9085      9087    +2     
  Branches      1045      1046    +1     
=========================================
+ Hits          9085      9087    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yitchen-tim yitchen-tim marked this pull request as ready for review February 10, 2025 18:15
@yitchen-tim yitchen-tim requested a review from a team as a code owner February 10, 2025 18:15
@yitchen-tim yitchen-tim merged commit d3aa29b into main Feb 10, 2025
26 checks passed
@yitchen-tim yitchen-tim deleted the yitchen/fix-job-decorator branch February 10, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants