Uses an iterator that adapts from SymbolToken to String in MacroEvaluatorAsIonReader.iterateTypeAnnotations instead of eagerly allocating a new collection. #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobarr-amzn
reviewed
Jan 16, 2025
Comment on lines
160
to
165
| override fun next(): String { | ||
| return tokens[index++].assumeText() | ||
| } |
There was a problem hiding this comment.
This ought to throw NoSuchElementException when index >= tokens.size (see Iterator.next), but this will instead throw ArrayIndexOutOfBoundsException.
…atorAsIonReader.iterateTypeAnnotations instead of eagerly allocating a new collection.
tgregg
force-pushed
the
ion-11-encoding-optimize-evaluator-annotation-iterator
branch
from
2041189 to
ece2e55
Compare
jobarr-amzn
approved these changes
Jan 16, 2025
tgregg
deleted the
ion-11-encoding-optimize-evaluator-annotation-iterator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Before: 264 ms/op
After: 253 ms/op (-4.2%)
We may be able to improve performance further by reusing the iterator.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.