Adds support for reading binary Ion 1.1 timestamps. #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Nov 16, 2023
Comment on lines
583
to
584
| int month = 0; | ||
| int day = 0; |
There was a problem hiding this comment.
Should these default to 1?
There was a problem hiding this comment.
Sure, it doesn't end up mattering because Timestamp does its own defaulting, but it looks better with them set to valid values.
Comment on lines
654
to
655
| int month = 0; | ||
| int day = 0; |
There was a problem hiding this comment.
Same as above. Should these default to 1?
| public static final int NANOSECOND_SCALE = 9; | ||
| public static final int MAX_MICROSECONDS = 999999; | ||
| public static final int MICROSECOND_SCALE = 6; | ||
| public static final short MAX_MILLISECONDS = 999; |
There was a problem hiding this comment.
Any particular reason why this one is a short instead of an int?
…o address PR feedback.
…s more tests for numeric types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Short and long-form, as of the current revision of the Ion 1.1 spec. Reading the fractional component of long-form timestamps will change slightly if amazon-ion/ion-docs#286 is merged.
I copied the CsvSource parameters from IonEncoder_1_1Test. Ideally we'd be able to share these more easily, but a
static final String[]isn't accepted by JUnit. Leaving that for future improvement. Additional test coverage should probably come from ion-tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.