Adds support for reading binary Ion 1.1 nulls, booleans, ints, and floats. #641
Conversation
| " -2147483648, 54 00 00 00 80", // Integer.MIN_VALUE | ||
| " -72624976668147841, 58 7F BF DF EF F7 FB FD FE", | ||
| " -9223372036854775808, 58 00 00 00 00 00 00 00 80", // Long.MIN_VALUE | ||
| }) |
There was a problem hiding this comment.
Should there be cases for reading variable-length integers as int and long?
For example "1, F5 03 01" and "1, F5 09 01 00 00 00" and "0, F5 01"?
There was a problem hiding this comment.
Yes there should be, somewhere. I hadn't intended these unit test parameters to cover all edge cases, thinking that would be a better job for the ion-tests files. But I'm happy to add some more cases here for now, giving us a head start on developing a more exhaustive Ion 1.1 ion-tests corpus.
There was a problem hiding this comment.
| " NaN, 5C 7F C0 00 00", | ||
| " Infinity, 5C 7F 80 00 00", | ||
| " -Infinity, 5C FF 80 00 00", |
There was a problem hiding this comment.
Should be able to read these as any size of float.
| " NaN, 5C 7F C0 00 00", | |
| " Infinity, 5C 7F 80 00 00", | |
| " -Infinity, 5C FF 80 00 00", | |
| " NaN, 5C 7F C0 00 00", | |
| " Infinity, 5C 7F 80 00 00", | |
| " -Infinity, 5C FF 80 00 00", | |
| " NaN, 5D 7F C0 00 00 00 00 00 00", | |
| " Infinity, 5D 7F 80 00 00 00 00 00 00", | |
| " -Infinity, 5D FF 80 00 00 00 00 00 00", |
There was a problem hiding this comment.
|
|
||
| @ParameterizedTest | ||
| @CsvSource({ | ||
| " 0.0, 5A", |
There was a problem hiding this comment.
Test cases to make sure it can read 0 of any size.
| " 0.0, 5A", | |
| " 0.0, 5A", | |
| " 0.0, 5B 00 00", | |
| " 0.0, 5C 00 00 00 00", | |
| " 0.0, 5D 00 00 00 00 00 00 00 00", |
There was a problem hiding this comment.
| " 0, 50", | ||
| " 1, 51 01", | ||
| " 17, 51 11", | ||
| " 127, 51 7F", |
There was a problem hiding this comment.
Numbers such as 127 can be encoded using more than one op code. We should add tests for that here (and in the other integer tests).
| " 127, 51 7F", | |
| " 127, 51 7F", | |
| " 127, 52 7F 00", | |
| " 127, 54 7F 00 00 00", | |
| " 127, 58 7F 00 00 00 00 00 00 00", |
There was a problem hiding this comment.
…o address PR feedback.
…s more tests for numeric types.
Description of changes:
Adds support for reading binary Ion 1.1 nulls, booleans, ints, and floats.
The trickiest part of this was actually the typed nulls, since they now require looking ahead one byte rather than relying on the type being baked into the precomputed type ID. For convenience and simplicity, we solve this by replacing the reader's type ID with the Ion 1.0 typed null IonTypeID instance for the given type, once the type is determined.
Note that for float values, the only changes required were in the type ID assignments, which happened in #639.
The test parameters are once again copied from IonEncoder_1_1Test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.