Adds support for reading binary Ion 1.1 decimals. #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
reviewed
Nov 21, 2023
| /** | ||
| * Reads into a BigDecimal the decimal value that begins at `peekIndex` and ends at `valueMarker.endIndex`. | ||
| * @return the value. | ||
| */ | ||
| private BigDecimal readBigDecimal_1_1() { |
There was a problem hiding this comment.
Do we actually need this, given that Decimal extends BigDecimal?
There was a problem hiding this comment.
Only for performance reasons. See the comment in readDecimal_1_1().
| } | ||
|
|
||
| @ParameterizedTest | ||
| @CsvSource({ |
There was a problem hiding this comment.
Can you add a few test cases for reading numbers that are encoded with a longer-than-necessary length or using the variable length op code for a small number? E.g.
14, 64 01 0E 00 0014, F6 05 01 0E0., F6 03 01
There was a problem hiding this comment.
The next test covers the latter two. I can add some overpadded examples too.
| " 3.141592653589793238462643383, F6 1B CB B7 3C 92 86 40 9F 1B 01 1F AA 26 0A", | ||
| " 3.14159265358979323846264338327950, F6 1F C1 8E 29 E5 E3 56 D5 DF C5 10 8F 55 3F 7D 0F", | ||
| }) | ||
| public void readDecimalValue(@ConvertWith(TestUtils.StringToDecimal.class) Decimal expectedValue, String inputBytes) throws Exception { |
There was a problem hiding this comment.
This test has only variable-length encoding cases. Did the test names get swapped by mistake?
tgregg
force-pushed
the
ion-11-read-decimals
branch
from
92365d7 to
d749378
Compare
popematt
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Read Ion 1.1 decimals as BigDecimal or Decimal. Only the latter supports negative zero. The changes to IonTypeID are to comply with amazon-ion/ion-docs#286.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.