Adds the ability to read an Ion int as a Java double, Decimal, or BigDecimal for consistency with the previous implementation. #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
============================================
+ Coverage 67.06% 67.23% +0.17%
- Complexity 5469 5481 +12
============================================
Files 159 159
Lines 22970 22995 +25
Branches 4116 4121 +5
============================================
+ Hits 15404 15460 +56
+ Misses 6286 6257 -29
+ Partials 1280 1278 -2 ☔ View full report in Codecov by Sentry. |
rmarrowstone
approved these changes
Dec 15, 2023
| scalarConverter.addValue(decimalValue()); | ||
| scalarConverter.setAuthoritativeType(_Private_ScalarConversions.AS_TYPE.decimal_value); | ||
| scalarConverter.cast(scalarConverter.get_conversion_fnid(_Private_ScalarConversions.AS_TYPE.double_value)); | ||
| value = scalarConverter.getDouble(); | ||
| scalarConverter.clear(); | ||
| } else if (valueTid.type == IonType.INT) { | ||
| scalarConverter.addValue(longValue()); |
There was a problem hiding this comment.
Do we know that the previous implementation only worked for Ion Ints that fit in a long?
There was a problem hiding this comment.
I double-checked and unfortunately it looks like it would work, so I added support.
| next(IonType.INT), doubleValue(255.0), | ||
| next(null) | ||
| ); | ||
| closeAndCount(); | ||
| } |
There was a problem hiding this comment.
Whether we support coercing arbitrary size Ints or not we should have a test for that.
…Decimal for consistency with the previous implementation.
tgregg
force-pushed
the
int-as-double
branch
from
a0c28d2 to
06452e0
Compare
tgregg
changed the title
|
Revision 2: added conversions to Decimal and BigDecimal; added support for conversions from int values that require BigInteger. |
rmarrowstone
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #674
Closes #677
Description of changes:
See the linked issue. Note: I am not changing the documentation or associated error messages to officially endorse doing this. In fact, this would be one of the conversions we'd want to remove as part of #523. For now, we preserve the previous undocumented behavior to avoid breaking a small number of users that depend on it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.