Moves read
logic for FlexInt, FlexUInt into inherent impls
#2051
Annotations
12 errors and 9 warnings
unnecessary map of the identity function:
src/types/struct.rs#L240
error: unnecessary map of the identity function
--> src/types/struct.rs:240:30
|
240 | .get(field_index)
| ______________________________^
241 | | .map(|(name, value)| (name, value))
| |_______________________________________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
|
unnecessary map of the identity function:
src/types/struct.rs#L172
error: unnecessary map of the identity function
--> src/types/struct.rs:172:20
|
172 | .iter()
| ____________________^
173 | | // Here we convert from &(name, value) to (&name, &value).
174 | | // The former makes a stronger assertion about how the data is being stored. We don't
175 | | // want that to be a mandatory part of the public API.
176 | | .map(|(name, element)| (name, element))
| |___________________________________________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `-D clippy::map-identity` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::map_identity)]`
|
items after a test module:
src/text/parsers/timestamp.rs#L280
error: items after a test module
--> src/text/parsers/timestamp.rs:280:1
|
280 | mod reader_tests {
| ^^^^^^^^^^^^^^^^
...
456 | pub(crate) fn digit(input: &str) -> IResult<&str, char> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module
= note: `-D clippy::items-after-test-module` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::items_after_test_module)]`
= help: move the items to before the test module was defined
|
unnecessary map of the identity function:
src/types/struct.rs#L240
error: unnecessary map of the identity function
--> src/types/struct.rs:240:30
|
240 | .get(field_index)
| ______________________________^
241 | | .map(|(name, value)| (name, value))
| |_______________________________________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
|
unnecessary map of the identity function:
src/types/struct.rs#L172
error: unnecessary map of the identity function
--> src/types/struct.rs:172:20
|
172 | .iter()
| ____________________^
173 | | // Here we convert from &(name, value) to (&name, &value).
174 | | // The former makes a stronger assertion about how the data is being stored. We don't
175 | | // want that to be a mandatory part of the public API.
176 | | .map(|(name, element)| (name, element))
| |___________________________________________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `-D clippy::map-identity` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::map_identity)]`
|
unused import: `crate::lazy::binary::immutable_buffer::ParseResult`:
src/lazy/encoder/binary/v1_1/flex_uint.rs#L1
error: unused import: `crate::lazy::binary::immutable_buffer::ParseResult`
--> src/lazy/encoder/binary/v1_1/flex_uint.rs:1:5
|
1 | use crate::lazy::binary::immutable_buffer::ParseResult;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::element::Sequence`:
src/types/mod.rs#L19
error: unused import: `crate::element::Sequence`
--> src/types/mod.rs:19:9
|
19 | pub use crate::element::Sequence;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
unused imports: `ion_list`, `ion_sexp`, `ion_struct`:
src/element/builders.rs#L375
error: unused imports: `ion_list`, `ion_sexp`, `ion_struct`
--> src/element/builders.rs:375:10
|
375 | pub use {ion_list, ion_sexp, ion_struct};
| ^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
|
unused import: `crate::lazy::binary::immutable_buffer::ParseResult`:
src/lazy/encoder/binary/v1_1/flex_uint.rs#L1
error: unused import: `crate::lazy::binary::immutable_buffer::ParseResult`
--> src/lazy/encoder/binary/v1_1/flex_uint.rs:1:5
|
1 | use crate::lazy::binary::immutable_buffer::ParseResult;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::element::Sequence`:
src/types/mod.rs#L19
error: unused import: `crate::element::Sequence`
--> src/types/mod.rs:19:9
|
19 | pub use crate::element::Sequence;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
unused imports: `ion_list`, `ion_sexp`, `ion_struct`:
src/element/builders.rs#L375
error: unused imports: `ion_list`, `ion_sexp`, `ion_struct`
--> src/element/builders.rs:375:10
|
375 | pub use {ion_list, ion_sexp, ion_struct};
| ^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
|
Build and Test (ubuntu-latest)
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255
|
Build and Test (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Build and Test (ubuntu-latest):
src/element/builders.rs#L375
unused imports: `ion_list`, `ion_sexp`, `ion_struct`
|
Build and Test (ubuntu-latest):
src/types/mod.rs#L19
unused import: `crate::element::Sequence`
|
Build and Test (ubuntu-latest):
src/lazy/encoder/binary/v1_1/flex_uint.rs#L1
unused import: `crate::lazy::binary::immutable_buffer::ParseResult`
|
Build and Test (ubuntu-latest)
`ion-rs` (lib) generated 3 warnings (run `cargo fix --lib -p ion-rs` to apply 3 suggestions)
|
Build and Test (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Build and Test (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Build and Test (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Build and Test (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|