Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds reader for timestamp_offset and timestamp_precision #266

Merged
merged 1 commit into from
May 25, 2023

Conversation

popematt
Copy link
Contributor

Issue #, if available:

#256

Description of changes:

Adds readers for timestamp_offset and timestamp_precision; updates the ReaderTests accordingly.

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 92.59% and project coverage change: +0.33 🎉

Comparison is base (e2f01e4) 82.50% compared to head (7ba8b8f) 82.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   82.50%   82.84%   +0.33%     
==========================================
  Files         127      129       +2     
  Lines        3149     3176      +27     
  Branches      744      750       +6     
==========================================
+ Hits         2598     2631      +33     
+ Misses        327      322       -5     
+ Partials      224      223       -1     
Impacted Files Coverage Δ
...lin/com/amazon/ionschema/reader/internal/ranges.kt 85.71% <81.81%> (+3.49%) ⬆️
...amazon/ionschema/reader/internal/TypeReaderV2_0.kt 92.85% <100.00%> (+0.21%) ⬆️
...ader/internal/constraints/TimestampOffsetReader.kt 100.00% <100.00%> (ø)
...r/internal/constraints/TimestampPrecisionReader.kt 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@popematt popematt requested a review from desaikd May 24, 2023 21:34
@popematt popematt merged commit b774d33 into amazon-ion:master May 25, 2023
@popematt popematt deleted the read-timestamp branch June 13, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants